From: Eli Zaretskii <eliz@gnu.org>
To: Federico Tedin <federicotedin@gmail.com>, Tassilo Horn <tsdh@gnu.org>
Cc: 33684@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#33684: DocView bombs out upon password protected PDFs
Date: Fri, 01 Feb 2019 11:33:55 +0200 [thread overview]
Message-ID: <83womjyhrw.fsf@gnu.org> (raw)
In-Reply-To: <87sgxesv6u.fsf@gmail.com> (message from Federico Tedin on Sat, 26 Jan 2019 23:14:49 -0300)
> From: Federico Tedin <federicotedin@gmail.com>
> Date: Sat, 26 Jan 2019 23:14:49 -0300
Thanks.
Tassilo, any comments on the proposal below? Should I push it?
> 積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
>
> > When trying to view a password protected PDF:
> > DocView: process pdf/ps->png changed status to exited abnormally with code 1.
> > Maybe it should ask for the password.
> > emacs-version "25.2.2"
>
> Would something like this make sense? A short patch that adds
> `doc-view-pdf-password-protected-p', and an extra option to pass to
> Ghostscript (-sPDFPassword=) when the command is invoked (only when the
> PDF file is password protected). I tried it out by creating a
> password-protected PDF using LibreOffice Writer, and then opening it
> with find-file.
>
>
> diff --git a/lisp/doc-view.el b/lisp/doc-view.el
> index df8a9fc70f..8691d2a3a6 100644
> --- a/lisp/doc-view.el
> +++ b/lisp/doc-view.el
> @@ -183,11 +183,16 @@ doc-view-pdf->png-converter-function
> (defcustom doc-view-ghostscript-options
> '("-dSAFER" ;; Avoid security problems when rendering files from untrusted
> ;; sources.
> - "-dNOPAUSE" "-sDEVICE=png16m" "-dTextAlphaBits=4"
> - "-dBATCH" "-dGraphicsAlphaBits=4" "-dQUIET")
> + "-dNOPAUSE" "-dTextAlphaBits=4" "-dBATCH"
> + "-dGraphicsAlphaBits=4" "-dQUIET")
> "A list of options to give to ghostscript."
> :type '(repeat string))
>
> +(defcustom doc-view-ghostscript-device "png16m"
> + "Output device to give to ghostscript."
> + :type 'string
> + :version "27.1")
> +
> (defcustom doc-view-resolution 100
> "Dots per inch resolution used to render the documents.
> Higher values result in larger images."
> @@ -950,16 +955,30 @@ doc-view-dvi->pdf
> (list "-o" pdf dvi)
> callback)))
>
> +(defun doc-view-pdf-password-protected-p (pdf)
> + "Using Ghostscript, check if a PDF file is password-protected."
> + (with-temp-buffer
> + (apply #'call-process doc-view-ghostscript-program nil (current-buffer)
> + nil `(,@doc-view-ghostscript-options
> + "-sNODISPLAY"
> + ,pdf))
> + (goto-char (point-min))
> + (search-forward "This file requires a password for access." nil t)))
> +
> (defun doc-view-pdf->png-converter-ghostscript (pdf png page callback)
> - (doc-view-start-process
> - "pdf/ps->png" doc-view-ghostscript-program
> - `(,@doc-view-ghostscript-options
> - ,(format "-r%d" (round doc-view-resolution))
> - ,@(if page `(,(format "-dFirstPage=%d" page)))
> - ,@(if page `(,(format "-dLastPage=%d" page)))
> - ,(concat "-sOutputFile=" png)
> - ,pdf)
> - callback))
> + (let ((pdf-passwd (if (doc-view-pdf-password-protected-p pdf)
> + (read-passwd "Enter password for PDF file: "))))
> + (doc-view-start-process
> + "pdf/ps->png" doc-view-ghostscript-program
> + `(,@doc-view-ghostscript-options
> + ,(concat "-sDEVICE=" doc-view-ghostscript-device)
> + ,(format "-r%d" (round doc-view-resolution))
> + ,@(if page `(,(format "-dFirstPage=%d" page)))
> + ,@(if page `(,(format "-dLastPage=%d" page)))
> + ,@(if pdf-passwd `(,(format "-sPDFPassword=%s" pdf-passwd)))
> + ,(concat "-sOutputFile=" png)
> + ,pdf)
> + callback)))
>
> (defalias 'doc-view-ps->png-converter-ghostscript
> 'doc-view-pdf->png-converter-ghostscript)
next prev parent reply other threads:[~2019-02-01 9:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 10:52 bug#33684: DocView bombs out upon password protected PDFs 積丹尼 Dan Jacobson
2019-01-27 2:14 ` Federico Tedin
2019-02-01 9:33 ` Eli Zaretskii [this message]
2019-02-01 10:12 ` Tassilo Horn
2019-02-01 10:34 ` Eli Zaretskii
2019-02-01 10:42 ` Federico Tedin
2019-02-02 20:58 ` Federico Tedin
2019-02-03 8:40 ` Tassilo Horn
2019-02-03 16:55 ` Federico Tedin
2019-02-04 5:44 ` Tassilo Horn
2019-02-04 6:29 ` Eli Zaretskii
2019-02-04 6:52 ` Tassilo Horn
2019-02-04 15:49 ` Tassilo Horn
2019-02-04 21:24 ` Federico Tedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83womjyhrw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33684@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
--cc=jidanni@jidanni.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).