From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Wed, 24 Apr 2019 20:43:47 +0300 Message-ID: <83wojj1ep8.fsf@gnu.org> References: <87sh806xwa.fsf@chapu.is> <83y349gasn.fsf@gnu.org> <83d0lfag4x.fsf@gnu.org> <5cf45a21-65c3-67ee-f123-be83a6ee7c99@yandex.ru> <83a7gjaen6.fsf@gnu.org> <83ftqa8qsg.fsf@gnu.org> <83muki6y6r.fsf@gnu.org> <4b8c6799-e845-768b-749c-f2a883ab89f8@yandex.ru> <83h8aq6v6a.fsf@gnu.org> <834l6q6ozn.fsf@gnu.org> <83zhoi59ao.fsf@gnu.org> <83wojm57sl.fsf@gnu.org> <83ftq96azk.fsf@gnu.org> <83wojk534g.fsf@gnu.org> <6308ceff-479b-2ce7-2072-41e683978c7c@yandex.ru> <83h8ao4vl0.fsf@gnu.org> <835zr32x2m.fsf@gnu.org> <8f3318e9-25bd-c7af-20dd-ed78d2a92efd@yandex.ru> <831s1r2uzx.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="242281"; mail-complaints-to="usenet@blaine.gmane.org" Cc: sebastien@chapu.is, yyoncho@gmail.com, 31138@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 24 19:56:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJM7k-0010tN-9e for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 19:56:00 +0200 Original-Received: from localhost ([127.0.0.1]:45212 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJM7j-0002MV-7y for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 13:55:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJM6J-00015a-Pw for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 13:54:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJLx8-0001mA-Qt for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 13:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJLx8-0001m1-No for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 13:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJLx8-0002Dp-Hj for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2019 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.15561278468466 (code B ref 31138); Wed, 24 Apr 2019 17:45:02 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 24 Apr 2019 17:44:06 +0000 Original-Received: from localhost ([127.0.0.1]:56439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJLwC-0002CS-LZ for submit@debbugs.gnu.org; Wed, 24 Apr 2019 13:44:06 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJLwA-0002Br-06 for 31138@debbugs.gnu.org; Wed, 24 Apr 2019 13:44:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJLw4-0000fv-3O; Wed, 24 Apr 2019 13:43:56 -0400 Original-Received: from [176.228.60.248] (port=2978 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hJLw3-0004Kb-Ec; Wed, 24 Apr 2019 13:43:55 -0400 In-reply-to: (message from Dmitry Gutov on Wed, 24 Apr 2019 20:36:56 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158193 Archived-At: > Cc: sebastien@chapu.is, yyoncho@gmail.com, 31138@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 24 Apr 2019 20:36:56 +0300 > > On 24.04.2019 20:06, Eli Zaretskii wrote: > > > No, I think it's decoded by low-level code which reads output from the > > process. At least by default. > > But what conversion primitives does that low-level code use? > code_convert_region? AFAICS, it uses decode_coding_c_string. Incoming data doesn't have to be UTF-8, mind you, it could be anything, including an unknown encoding that needs detecting, and only the detection tells us it's UTF-8. > > The question is, do we want to signal an error ourselves, or do we > > want to rely on the library? > > Relying on the library is probably faster. Why faster? And more importantly, will the error indication be useful enough to the Lisp program that triggered it? If we signal an error, we can make sure of that. > I'll happily benchmark a patch, if you have any. OK.