unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 36830@debbugs.gnu.org, gusbrs.2016@gmail.com
Subject: bug#36830: 26.2; find-file-visit-truename is not honored as file local variable
Date: Sun, 25 Aug 2019 10:31:32 +0300	[thread overview]
Message-ID: <83wof1hfaj.fsf@gnu.org> (raw)
In-Reply-To: <87blwdajn2.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun,  25 Aug 2019 07:39:29 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: gusbrs.2016@gmail.com,  36830@debbugs.gnu.org
> Date: Sun, 25 Aug 2019 07:39:29 +0200
> 
> > Maybe we should just document that this variable cannot be file-local.
> 
> files.el has this:
> 
> (put 'find-file-visit-truename 'safe-local-variable 'booleanp)
> 
> It was changed to booleanp in 2007 (from the presumably invalid
> `boolean'), so it didn't work before 2007 for that reason, and it hasn't
> worked after 2007 because it's checked too late.
> 
> So perhaps the fix here is to just remove that `put'?

Fine with me.

> On the other hand, it would be nice if it worked, because it seems like
> a pretty useful thing to be able to customise on a per-file basis.

I agree.  If someone can come up with a way to resolve the race, I'm
all ears.

We have similar problems in startup.el, with variables that depend on
potentially customizable other variables, and the solutions are... not
pretty and quite fragile.  In particular, that kind of problems was
the main reason why we introduced the early-init file.





  reply	other threads:[~2019-08-25  7:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-28 15:21 bug#36830: 26.2; find-file-visit-truename is not honored as file local variable Gustavo Barros
2019-08-23  5:05 ` Lars Ingebrigtsen
2019-08-23 13:04   ` Gustavo Barros
2019-08-23 18:59     ` Lars Ingebrigtsen
2019-08-23 20:07       ` Eli Zaretskii
2019-08-23 21:38         ` Gustavo Barros
2019-08-25  5:39         ` Lars Ingebrigtsen
2019-08-25  7:31           ` Eli Zaretskii [this message]
2019-10-14 21:38             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wof1hfaj.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=36830@debbugs.gnu.org \
    --cc=gusbrs.2016@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).