From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37852: Build failure on MSYS2 (undefined reference to _chk functions) Date: Mon, 21 Oct 2019 19:36:17 +0300 Message-ID: <83wocy12f2.fsf@gnu.org> References: <83k18y2qnd.fsf@gnu.org> <83eez62pir.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="166241"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37852@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 18:37:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMagC-000h0t-CZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 18:37:12 +0200 Original-Received: from localhost ([::1]:45170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMagB-00079h-0W for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 12:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38766) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMag2-00076l-PZ for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 12:37:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMag1-0003tu-Q3 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 12:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48907) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMag1-0003tp-N2 for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 12:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMag1-00077N-JK for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 12:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Oct 2019 16:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37852 X-GNU-PR-Package: emacs Original-Received: via spool by 37852-submit@debbugs.gnu.org id=B37852.157167579927331 (code B ref 37852); Mon, 21 Oct 2019 16:37:01 +0000 Original-Received: (at 37852) by debbugs.gnu.org; 21 Oct 2019 16:36:39 +0000 Original-Received: from localhost ([127.0.0.1]:57728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMafa-00076e-DY for submit@debbugs.gnu.org; Mon, 21 Oct 2019 12:36:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMafV-00076L-F0 for 37852@debbugs.gnu.org; Mon, 21 Oct 2019 12:36:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iMafQ-0003p2-8g; Mon, 21 Oct 2019 12:36:24 -0400 Original-Received: from [176.228.60.248] (port=1204 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iMafP-0002Dl-Lh; Mon, 21 Oct 2019 12:36:24 -0400 In-reply-to: (message from Andy Moreton on Mon, 21 Oct 2019 17:05:35 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169928 Archived-At: > From: Andy Moreton > Date: Mon, 21 Oct 2019 17:05:35 +0100 > > > So do we need to add that library to the link command under some > > conditions? IOW, is FORTIFY_SOURCE something that comes out of our > > configure script (in which case I'm missing something, because I > > didn't find it in the configure script), or is this an option you > > added manually? In the latter case, would configuring with LIBS=-lssp > > be an okay solution? > > See GNULIB_PORTCHECK_FORTIFY_SOURCE in configure.ac - the relevant macro > is _FORTIFY_SOURCE. Thanks, I indeed missed that. > Building with -D_FORTIFY_SOURCE=0 also works, but your suggestion to add > the missing library is a better workaround than disabling the checks. The problem with using -lssp unconditionally is that some installations might not have it, and then the linker will barf. So I think we should better disable GNULIB_PORTCHECK on MinGW (I can hardly imagine someone using that platform for those portability checks, and I'm not sure I understand why this gets defined by default on other platforms).