From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Fri, 14 Feb 2020 17:45:56 +0200 Message-ID: <83wo8pnpe3.fsf@gnu.org> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <83d0ahpkzu.fsf@gnu.org> <6f06f4c8-17c0-31a7-a6d8-e40686b1e987@yandex.ru> <83y2t5ntm6.fsf@gnu.org> <360947a9-3828-a97d-1ddf-6990344e8f77@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="107895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: npostavs@gmail.com, 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 14 16:46:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2dAU-000RzI-QE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 16:46:14 +0100 Original-Received: from localhost ([::1]:40516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2dAT-0003di-RL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Feb 2020 10:46:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52306) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2dAJ-0003bU-63 for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 10:46:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2dAI-0005GI-5i for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 10:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56742) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j2dAI-0005GA-2B for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 10:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j2dAI-00037i-0Y for bug-gnu-emacs@gnu.org; Fri, 14 Feb 2020 10:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Feb 2020 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.158169516111999 (code B ref 39452); Fri, 14 Feb 2020 15:46:01 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 14 Feb 2020 15:46:01 +0000 Original-Received: from localhost ([127.0.0.1]:34482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2dAG-00037R-Ny for submit@debbugs.gnu.org; Fri, 14 Feb 2020 10:46:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j2dAD-000378-W8 for 39452@debbugs.gnu.org; Fri, 14 Feb 2020 10:45:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j2dA8-0004wo-6q; Fri, 14 Feb 2020 10:45:52 -0500 Original-Received: from [176.228.60.248] (port=3578 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j2dA7-0001zg-GR; Fri, 14 Feb 2020 10:45:51 -0500 In-reply-to: <360947a9-3828-a97d-1ddf-6990344e8f77@yandex.ru> (message from Dmitry Gutov on Fri, 14 Feb 2020 16:40:04 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176057 Archived-At: > Cc: npostavs@gmail.com, 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de > From: Dmitry Gutov > Date: Fri, 14 Feb 2020 16:40:04 +0200 > > On 14.02.2020 16:14, Eli Zaretskii wrote: > > Any command that prompts for a file name, I guess. vc-delete-file and > > vc-rename-file come to mind. > > In both of these commands entering a non-trivial pathspec is both > undocumented and hard to do: look at the interactive form, it calls > read-file-name with MUSTMATCH t. In other words, it doesn't let you > input interactively anything that's not an existing file name. > > > But my comment was more general: we don't plan on not supporting Git > > specs in file names, do we? > > I don't see how we'd keep supporting them in these two particular > commands without keeping bugs similar to this one unfixed (e.g. 'M-x > vc-delete-file test[56].xx' where test[56].xx is an existing filename). > > AFAICS, they're working purely by accident. That's not to say we can't > introduce new versions of these commands that would accept pathspecs (or > do it with C-u, etc). I won't argue. I just wanted to point out that using Git signatures internally might get in the way, whereas environment variables and command-line switches are free from that disadvantage.