bug#40124: Bad interaction between before-string and :box faces

bug#40124: Bad interaction between before-string and :box faces

[Clément Pit-Claudel]

Hi all,

In the following sample, the word "test" should have its letters "e" and "s" in a box; but instead they display with just a bar above and below.  Removing the before-string property fixes the issue.

(with-current-buffer (get-buffer-create "box-test")
  (erase-buffer)
  (insert "test")
  (let ((ov (make-overlay 2 4)))
    (overlay-put ov 'face '(:box t))
    (overlay-put ov 'before-string
                 (propertize ">" 'display
                             '(left-fringe right-arrow))))
  (pop-to-buffer (current-buffer)))

This was reported by Artemios (cc'd) in https://github.com/flycheck/flycheck/issues/1666.

Clément.

In GNU Emacs 28.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10)
 of 2020-03-15 built on clem-w50-mint
Repository revision: 9dccaf8a5cdb10dae597345ec3741475477a7d97
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Linux Mint 19.3

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Quit
Quit
Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD
JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LC_MONETARY: en_DK.UTF-8
  value of $LC_NUMERIC: en_DK.UTF-8
  value of $LC_TIME: en_DK.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 45837 8028)
 (symbols 48 6335 1)
 (strings 32 15873 1580)
 (string-bytes 1 514757)
 (vectors 16 10222)
 (vector-slots 8 138545 7900)
 (floats 8 19 41)
 (intervals 56 185 0)
 (buffers 1000 11))

bug#40124: Bad interaction between before-string and :box faces

[Eli Zaretskii]

> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
> Date: Wed, 18 Mar 2020 15:26:38 -0400
> Cc: demisbalbach@googlemail.com
> 
> In the following sample, the word "test" should have its letters "e" and "s" in a box; but instead they display with just a bar above and below.  Removing the before-string property fixes the issue.
> 
> (with-current-buffer (get-buffer-create "box-test")
>   (erase-buffer)
>   (insert "test")
>   (let ((ov (make-overlay 2 4)))
>     (overlay-put ov 'face '(:box t))
>     (overlay-put ov 'before-string
>                  (propertize ">" 'display
>                              '(left-fringe right-arrow))))
>   (pop-to-buffer (current-buffer)))
> 
> This was reported by Artemios (cc'd) in https://github.com/flycheck/flycheck/issues/1666.

Thanks, I think I fixed this now on the master branch.

bug#40124: Bad interaction between before-string and :box faces

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
>> Date: Wed, 18 Mar 2020 15:26:38 -0400
>> Cc: demisbalbach@googlemail.com
>>
>> In the following sample, the word "test" should have its letters "e" and "s" in a box; but instead they display with just a bar above and below.  Removing the before-string property fixes the issue.
>>
>> (with-current-buffer (get-buffer-create "box-test")
>>   (erase-buffer)
>>   (insert "test")
>>   (let ((ov (make-overlay 2 4)))
>>     (overlay-put ov 'face '(:box t))
>>     (overlay-put ov 'before-string
>>                  (propertize ">" 'display
>>                              '(left-fringe right-arrow))))
>>   (pop-to-buffer (current-buffer)))
>>
>> This was reported by Artemios (cc'd) in https://github.com/flycheck/flycheck/issues/1666.
>
> Thanks, I think I fixed this now on the master branch.

There has been no followup within 22 weeks, so I'm going to assume the
fix worked and close this bug now.

If this conclusion is incorrect, please reply to this email (use "Reply
to all" in your email client) and we can reopen the bug report.

Best regards,
Stefan Kangas