From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40695: [PATCH] ; Fix some typos and doc issues Date: Sat, 18 Apr 2020 16:47:18 +0300 Message-ID: <83wo6caot5.fsf@gnu.org> References: <20200418113735.34298-1-stepnem@gmail.com> <833691asgx.fsf@gnu.org> <87mu796io8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="72553"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40695@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 18 15:48:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPnpS-000InZ-JN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Apr 2020 15:48:18 +0200 Original-Received: from localhost ([::1]:58058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPnpR-0002tJ-LO for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Apr 2020 09:48:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55355) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPnpD-0002t6-Lk for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 09:48:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPnpC-0000Xy-IH for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 09:48:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jPnpC-0000XL-Ef for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 09:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jPnpC-0005Z1-DF for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2020 09:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Apr 2020 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40695-submit@debbugs.gnu.org id=B40695.158721765521347 (code B ref 40695); Sat, 18 Apr 2020 13:48:02 +0000 Original-Received: (at 40695) by debbugs.gnu.org; 18 Apr 2020 13:47:35 +0000 Original-Received: from localhost ([127.0.0.1]:42175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPnol-0005YF-CY for submit@debbugs.gnu.org; Sat, 18 Apr 2020 09:47:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jPnoj-0005Xx-5z for 40695@debbugs.gnu.org; Sat, 18 Apr 2020 09:47:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jPnoe-00087M-0T; Sat, 18 Apr 2020 09:47:28 -0400 Original-Received: from [176.228.60.248] (port=3126 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jPnod-0004AG-77; Sat, 18 Apr 2020 09:47:27 -0400 In-Reply-To: <87mu796io8.fsf@gmail.com> (message from =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= on Sat, 18 Apr 2020 15:13:27 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178571 Archived-At: > From: Štěpán Němec > Cc: 40695@debbugs.gnu.org > Date: Sat, 18 Apr 2020 15:13:27 +0200 > > If you prefer to limit the changes to only those necessary for > unsplitting the already split occurences, I'll do that. Either the split already occurs or is close (i.e. the offending text is close to the edge of a line. Otherwise we will have to put all of them in @w{..}, and that seems too much. > > >> -@strong{Warning:} if the changes you combine occur in widely scattered > >> +@strong{Warning:} If the changes you combine occur in widely scattered > > > > Not sure the original text is a typo. > > Indeed, it caught my eye for the reasons of consistency: all the other > "Warning:"s in text.texi, and most of those in other texi files, do > start with a capital, but not all of them, so if it seems too petty to > you I'll revert this (personally I dislike needless churn; e.g. I was > quite hesitant about the signalled -> signaled, too; I just bumped into > it inadvertently). The "signalled" thing is UK English, and we use US English, so your changes are okay. > >> (defvar cps--dynamic-wrappers '(identity) > >> - "List of transformer functions to apply to atomic forms we > >> -evaluate in CPS context.") > >> + "\ > >> +List of transformer functions applied to atomic forms evaluated in CPS context." > >> + ) > > > > This should be fixed by making the sentence shorter. The sentence is > > a mouthful, IMO. > > Heh. I did think about this really hard, but couldn't come up with > anything that would fit on a single line and not lose essential > information. Do you have any concrete suggestions? Something like List of functions to apply to atomic forms. These are transformer functions applied in the CPS context. > >> (defun cps--atomic-p (form) > >> - "Return whether the given form never yields." > >> - > >> + "Return non-nil if FORM never yields." > > > > Why this change? > > The original sentence sounds weird to me (what does the function really > return?), while the new version should be quite clear IMO. There's also > checkdoc nagging about `form' not being upper case. Well, double negation is also to be avoided. So how about Return nil if FORM can yield, non-nil otherwise. ? OK for the rest, thanks.