unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 40725@debbugs.gnu.org
Subject: bug#40725: 27.0.91; Tutorial reports false positive key rebindings
Date: Mon, 20 Apr 2020 17:28:21 +0300	[thread overview]
Message-ID: <83wo6agrju.fsf@gnu.org> (raw)
In-Reply-To: <87eesj59yq.fsf@tcd.ie> (contovob@tcd.ie)

> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Date: Mon, 20 Apr 2020 00:31:25 +0100
> 
> 0. emacs -Q
> 1. M-x winner-mode RET
> 2. C-h t
> 
> The user is then presented with the following:
> 
>  NOTICE: The main purpose of the Emacs tutorial is to teach you
>  the most important standard Emacs commands (key bindings).
>  However, your Emacs has been customized by changing some of
>  these basic editing commands, so it doesn't correspond to the
>  tutorial.  We have inserted colored notices where the altered
>  commands have been introduced. [More]
> 
> Yet no such coloured notices are to be found in TUTORIAL, since
> winner-mode binds only 'C-c <left>' and 'C-c <right>', neither of which
> is mentioned in the tutorial.
> 
> Pushing the "More" button gives the following *Help* buffer contents:
> 
> --8<---------------cut here---------------start------------->8---
> The following key bindings used in the tutorial have been changed
> from the Emacs default:
> 
>    Standard Key   Command                     In Your Emacs   
>    C-c 		  mode-specific-command-prefix M-x mode-specific-command-prefix more info
> 
> It is OK to change key bindings, but changed bindings do not
> correspond to what the tutorial says.
> --8<---------------cut here---------------end--------------->8---
> 
> Pushing the "more info" button in turn gives the following *Help* text:
> 
> --8<---------------cut here---------------start------------->8---
> Your Emacs customizations override the default binding for this key:
> 
> The default Emacs binding for the key C-c is the command
> ‘mode-specific-command-prefix’.  However, your customizations have
> rebound it to the command ‘(keymap (keymap (right . winner-redo) (left
> . winner-undo)) mode-specific-command-prefix)’.
> --8<---------------cut here---------------end--------------->8---
> 
> The following patch fixes this:

Isn't the patch too general?  How do we distinguish the case where
_all_ of the subcommands were rebound, for example?  Also, don't we
have some prefixes that for the purposes of the tutorial must not have
_any_ of its subcommands rebound?

> I don't think this qualifies as urgent enough for inclusion in emacs-27,
> but I think the fix is harmless enough if desired.  WDYT?

The release branch should at this point only accept changes that are
really urgent (and documentation fixes).  This one isn't, IMO.

Thanks.





  reply	other threads:[~2020-04-20 14:28 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19 23:31 bug#40725: 27.0.91; Tutorial reports false positive key rebindings Basil L. Contovounesios
2020-04-20 14:28 ` Eli Zaretskii [this message]
2020-04-20 22:19   ` Basil L. Contovounesios
2020-04-21 13:39     ` Eli Zaretskii
2020-04-22 22:26       ` Basil L. Contovounesios
2020-04-23 14:33         ` Eli Zaretskii
2020-04-23 21:52         ` Juri Linkov
2020-04-24  6:55           ` Eli Zaretskii
2020-04-25  3:31           ` Richard Stallman
2020-04-25  8:54           ` Eli Zaretskii
2020-04-25 20:42             ` Juri Linkov
2020-08-18 13:54         ` Lars Ingebrigtsen
2020-08-18 18:52           ` Basil L. Contovounesios
2020-08-19 10:20             ` Lars Ingebrigtsen
2021-11-12  8:28               ` Lars Ingebrigtsen
2021-11-14 23:24                 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-15  5:53                   ` Lars Ingebrigtsen
2020-04-24  8:46 ` Mattias Engdegård
2020-04-24 10:20   ` Eli Zaretskii
2020-04-24 10:41     ` Mattias Engdegård
2020-04-24 11:21       ` Eli Zaretskii
2020-04-24 11:35         ` Mattias Engdegård
2020-04-24 12:13           ` Eli Zaretskii
2020-04-24 12:47             ` Mattias Engdegård
2020-04-24 13:32               ` Eli Zaretskii
2020-04-24 16:01                 ` Mattias Engdegård
2020-04-25  3:33                 ` Richard Stallman
2020-04-25  6:20                   ` Eli Zaretskii
2020-04-27  2:18                     ` Richard Stallman
2020-04-27  2:37                       ` Eli Zaretskii
2020-04-27  6:11                       ` Andreas Schwab
2020-04-28  2:49                         ` Richard Stallman
2020-04-28  7:02                           ` Andreas Schwab
2020-04-29  3:25                             ` Richard Stallman
2020-04-29  7:30                               ` Eli Zaretskii
2020-04-30  2:32                                 ` Richard Stallman
2020-04-24 19:48             ` Kévin Le Gouguec
2020-04-24 19:57               ` Eli Zaretskii
2020-04-24 15:38           ` Dmitry Gutov
2020-04-24 15:51             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wo6agrju.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=40725@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).