From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36597: 27.0.50; rehash hash tables eagerly in pdumper Date: Wed, 12 Aug 2020 22:28:28 +0300 Message-ID: <83wo23mzoj.fsf@gnu.org> References: <83r26mv53z.fsf@gnu.org> <87ft8vbow1.fsf@gnus.org> <87v9hq4ppp.fsf@gnus.org> <83k0y544lf.fsf@gnu.org> <8bf60d70-6b0d-0e07-fef9-9baad9d7749c@cs.ucla.edu> <837du5p17p.fsf@gnu.org> <63d00359-f7cc-5564-ecf0-d374dea979ff@cs.ucla.edu> <83zh71ni7r.fsf@gnu.org> <80399aee-a2ef-5d24-a19e-5ea615190cf9@cs.ucla.edu> <83pn7wneed.fsf@gnu.org> <5d686746-a4aa-5864-d3b8-c58621d24279@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40399"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 36597@debbugs.gnu.org, pipcet@gmail.com To: Paul Eggert , Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 12 21:29:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5wQx-000ANy-Qo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 21:29:11 +0200 Original-Received: from localhost ([::1]:58020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5wQw-0005uZ-PG for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 15:29:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5wQo-0005sk-3Q for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 15:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5wQn-0001Bf-PI for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 15:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5wQn-0000Qg-Ml for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 15:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Aug 2020 19:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36597-submit@debbugs.gnu.org id=B36597.15972605291627 (code B ref 36597); Wed, 12 Aug 2020 19:29:01 +0000 Original-Received: (at 36597) by debbugs.gnu.org; 12 Aug 2020 19:28:49 +0000 Original-Received: from localhost ([127.0.0.1]:45627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5wQb-0000QB-1k for submit@debbugs.gnu.org; Wed, 12 Aug 2020 15:28:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5wQX-0000Pp-JP for 36597@debbugs.gnu.org; Wed, 12 Aug 2020 15:28:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40498) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5wQS-00018q-6f; Wed, 12 Aug 2020 15:28:40 -0400 Original-Received: from [176.228.60.248] (port=4019 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k5wQR-0004f6-7q; Wed, 12 Aug 2020 15:28:39 -0400 In-Reply-To: <5d686746-a4aa-5864-d3b8-c58621d24279@cs.ucla.edu> (message from Paul Eggert on Wed, 12 Aug 2020 12:11:09 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184869 Archived-At: > Cc: larsi@gnus.org, pipcet@gmail.com, 36597@debbugs.gnu.org > From: Paul Eggert > Date: Wed, 12 Aug 2020 12:11:09 -0700 > > I looked into the MinGW situation and the problem seems to be that MinGW defined > a macro _INTPTR_T_DEFINED that it no longer defines, and Gnulib was keying off > that no-longer-present macro. I think _INTPTR_T_DEFINED is still being used, but only by MinGW64. I use mingw.org's MinGW, where that macro was never used. However, both MinGW flavors typedef intptr_t as 'int', not 'long int', on 32-bit platforms. > I installed a patch for that in Gnulib here: > > https://lists.gnu.org/r/bug-gnulib/2020-08/msg00088.html > > and migrated the patch into Emacs. Hope it fixes things. It does here, thanks. I hope someone will be able to make sure MinGW64 builds are not adversely affected (I don't think they should be). > As an aside, we're spending too much time on pdumper.c code that has no effect > because dump_trace never outputs anything. How about if I remove dump_trace and > its callers? Although dump_trace may have been useful when the portable dumper > got developed, it's just a developer time sink now. I have no opinion on this, but I'd like to hear from Daniel (CC'ed) what he thinks.