From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode Date: Mon, 19 Oct 2020 22:02:04 +0300 Message-ID: <83wnzmnioj.fsf@gnu.org> References: <955fe4fe-a64d-b7c6-fe31-7efd810f97a5@ims.co.at> <83mu553e0x.fsf@gnu.org> <953c6df9-59b4-8b57-0be3-600d147fe9c7@ims.co.at> <83y2k2pabb.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: thomas.hisch@ims.co.at, 41852@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 19 21:08:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUaWY-000921-NH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 21:08:50 +0200 Original-Received: from localhost ([::1]:44102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUaWX-0006Cd-KT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 15:08:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUaQw-0008IT-Ol for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 15:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUaQw-0000tf-1G for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 15:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUaQv-0008Cx-UW for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 15:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Oct 2020 19:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41852-submit@debbugs.gnu.org id=B41852.160313412731487 (code B ref 41852); Mon, 19 Oct 2020 19:03:01 +0000 Original-Received: (at 41852) by debbugs.gnu.org; 19 Oct 2020 19:02:07 +0000 Original-Received: from localhost ([127.0.0.1]:42421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQ3-0008Bm-3j for submit@debbugs.gnu.org; Mon, 19 Oct 2020 15:02:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUaQ1-0008BB-CB for 41852@debbugs.gnu.org; Mon, 19 Oct 2020 15:02:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40095) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUaPu-0000mR-AL; Mon, 19 Oct 2020 15:01:58 -0400 Original-Received: from [176.228.60.248] (port=1547 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kUaPt-0004dp-G5; Mon, 19 Oct 2020 15:01:58 -0400 In-Reply-To: (message from Stefan Kangas on Mon, 19 Oct 2020 18:21:06 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191033 Archived-At: > From: Stefan Kangas > Date: Mon, 19 Oct 2020 18:21:06 +0000 > Cc: thomas.hisch@ims.co.at, 41852@debbugs.gnu.org > > > This should mention modes that arrange their display in tabular form > > below the header-line, such as tabulated-list-mode and its > > descendants. Otherwise the last sentence and the goal of the feature > > itself are left on a level that's too abstract. > > I've made an attempt to improve this in the attached. LGTM, thanks. > >> -(make-variable-buffer-local 'text-scale-mode-remapping) > >> +(make-obsolete-variable 'text-scale-mode-remapping "no longer used." "28.1") > >> + > >> +(defvar text-scale-mode--remappings nil > >> + "List of current remapping cookies for `text-scale-mode'.") > > > > Why this change? > > This is to give the variable the correct plural form, and to mark it > internal by giving it the double dash. Can we continue supporting text-scale-mode-remapping in text-scale-mode--remappings? I'd like to avoid backward-incompatible changes if possible. > >> +(defun face-remap--remap-face (sym) > >> + (push (face-remap-add-relative sym > >> + :height > >> + (expt text-scale-mode-step > >> + text-scale-mode-amount)) > >> + text-scale-mode--remappings)) > > > > I wonder whether this is all there is to it. The display code doesn't > > automatically use the remapped face in all cases, we need to code that > > "by hand" in each and every case. So far we've been doing that only > > for the default face; I wonder if we'll have to do something similar > > for header-line on the C level... Please be sure to test this in > > every possible way, including cursor motion around such rescaled > > header-lines etc. > > I've done my best to test it some more, including cursor motion around > the adjusted header line, as well as scrolling the window left and right > and up and down (using mouse and keyboard). I've not been able to > produce any failures so far. Please let me know if you have any more > ideas for what I could do to try to break it. Do mouse clicks work well, even if you click close to the edges of a much-enlarged header-line? Otherwise the changes look fine to me, thanks.