From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44858: [PATCH] Make byte-compiler warn about wide docstrings Date: Sat, 19 Dec 2020 13:22:50 +0200 Message-ID: <83wnxet4z9.fsf@gnu.org> References: <87zh34wfxo.fsf@gnus.org> <87v9dss2ic.fsf@gnus.org> <83mtyk3ig4.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11211"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44858@debbugs.gnu.org, larsi@gnus.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 19 12:24:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqaLK-0002ob-0o for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Dec 2020 12:24:10 +0100 Original-Received: from localhost ([::1]:35968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqaLI-0005UJ-Ro for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Dec 2020 06:24:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqaLC-0005UD-4r for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 06:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57580) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqaLB-0007q9-UK for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 06:24:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqaLB-0002sh-RA for bug-gnu-emacs@gnu.org; Sat, 19 Dec 2020 06:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Dec 2020 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44858-submit@debbugs.gnu.org id=B44858.160837699811016 (code B ref 44858); Sat, 19 Dec 2020 11:24:01 +0000 Original-Received: (at 44858) by debbugs.gnu.org; 19 Dec 2020 11:23:18 +0000 Original-Received: from localhost ([127.0.0.1]:40893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqaKT-0002rb-Nx for submit@debbugs.gnu.org; Sat, 19 Dec 2020 06:23:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqaKR-0002rO-Nl for 44858@debbugs.gnu.org; Sat, 19 Dec 2020 06:23:16 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54424) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqaKM-0007ZT-8r; Sat, 19 Dec 2020 06:23:10 -0500 Original-Received: from [176.228.60.248] (port=2776 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqaKL-0006Jy-J4; Sat, 19 Dec 2020 06:23:10 -0500 In-Reply-To: (message from Stefan Kangas on Fri, 11 Dec 2020 14:36:33 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196378 Archived-At: > From: Stefan Kangas > Date: Fri, 11 Dec 2020 14:36:33 -0600 > Cc: larsi@gnus.org, 44858@debbugs.gnu.org > > > Please show those problematic doc strings, and I will try to fix them. > > Thanks, I appreciate the help. Please see the below list that should be > easy to just put in a compilation-mode buffer. > > > gnus/deuglify.el:252:1: Warning: custom-declare-variable > `gnus-outlook-deuglify-unwrap-stop-chars' docstring wider than 80 > characters > gnus/deuglify.el:259:1: Warning: custom-declare-variable > `gnus-outlook-deuglify-no-wrap-chars' docstring wider than 80 characters > gnus/deuglify.el:265:1: Warning: custom-declare-variable > `gnus-outlook-deuglify-attrib-cut-regexp' docstring wider than 80 > characters > gnus/gnus.el:1529:1: Warning: custom-declare-variable > `gnus-group-charset-alist' docstring wider than 80 characters > gnus/nnvirtual.el:63:1: Warning: defvar `nnvirtual-mapping-table' docstring > wider than 80 characters > gnus/nnvirtual.el:66:1: Warning: defvar `nnvirtual-mapping-offsets' docstring > wider than 80 characters > gnus/nnvirtual.el:72:1: Warning: defvar `nnvirtual-mapping-reads' docstring > wider than 80 characters > gnus/nnvirtual.el:75:1: Warning: defvar `nnvirtual-mapping-marks' docstring > wider than 80 characters > gnus/nnvirtual.el:78:1: Warning: defvar `nnvirtual-info-installed' docstring > wider than 80 characters > language/ethio-util.el:122:1: Warning: defvar `ethio-quote-vowel-always' > docstring wider than 80 characters > language/ethio-util.el:127:1: Warning: defvar `ethio-W-sixth-always' docstring > wider than 80 characters > mail/feedmail.el:624:1: Warning: custom-declare-variable > `feedmail-sendmail-f-doesnt-sell-me-out' docstring wider than 80 > characters I fixed those. > mh-e/mh-e.el:2827:1: Warning: custom-declare-variable > `mh-invisible-header-fields' docstring wider than 80 characters > mh-e/mh-e.el:2850:1: Warning: custom-declare-variable > `mh-invisible-header-fields-default' docstring wider than 80 characters > net/dbus.el:79:1: Warning: defconst `dbus-interface-peer' docstring wider than > 80 characters > net/dbus.el:91:1: Warning: defconst `dbus-interface-introspectable' docstring > wider than 80 characters > net/dbus.el:102:1: Warning: defconst `dbus-interface-properties' docstring > wider than 80 characters > net/dbus.el:128:1: Warning: defconst `dbus-interface-objectmanager' docstring > wider than 80 characters > net/dbus.el:148:1: Warning: defconst `dbus-interface-monitoring' docstring > wider than 80 characters I see nothing wrong with these, so either I'm missing something or there's a bug in the code which reports these problems. > org/org-ctags.el:164:1: Warning: custom-declare-variable > `org-ctags-open-link-functions' docstring wider than 80 characters Fixed. > org/org-protocol.el:166:1: Warning: custom-declare-variable > `org-protocol-project-alist' docstring wider than 80 characters I don't see a problem here. > vc/ediff-init.el:556:1: Warning: custom-declare-variable > `ediff-before-flag-bol' docstring wider than 80 characters > vc/ediff-init.el:562:1: Warning: custom-declare-variable > `ediff-after-flag-eol' docstring wider than 80 characters > vc/ediff-init.el:568:1: Warning: custom-declare-variable > `ediff-before-flag-mol' docstring wider than 80 characters Fixed. > progmodes/cc-engine.el:183:1: Warning: defvar `c-vsemi-status-unknown-p-fn' > docstring wider than 80 characters I don't see how I can do anything about this one.