From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45428: 27.1; (quote (quote (quote ...))) unexpectedly works as anonymous face Date: Tue, 29 Dec 2020 21:39:29 +0200 Message-ID: <83wnx0ieq6.fsf@gnu.org> References: <<<<<>>>>> <<<<<<87eejc9pnm.fsf@gnus.org>>>>>> <<<<<>>>>> <<<<<<5e99c39b-b67b-4184-a890-2cae38fb40de@default>>>>>> <<<<<<87a6tzk5iv.fsf@metalevel.at>>>>>> <<<<<<83h7o7kufk.fsf@gnu.org>>>>>> <<<<<975c150b-99aa-4143-b057-8b5ec7caec19@default>>>>> <<<<<838s9jkqh7.fsf@gnu.org>>>>> <<<>>> <<<<835z4mkpvz.fsf@gnu.org>>>> <<<5dfff982-e496-46fe-9efd-1e0edd4f0be8@default>>> <<<83o8idkehc.fsf@gnu.org>>> <<<83mtxxkcwk.fsf@gnu.org>>> <<9a600718-7caf-4ad0-a664-0ebafba63e57@default>> <<83im8lk9lp.fsf@gnu.org>> <83eej8k6jw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38473"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, stefan@marxist.se, triska@metalevel.at, 45428@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 29 20:40:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kuKqu-0009tT-NJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 20:40:16 +0100 Original-Received: from localhost ([::1]:36394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuKqt-0001pN-AB for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Dec 2020 14:40:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuKqg-0001p2-CV for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 14:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuKqg-0003it-4X for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 14:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuKqg-0006sN-0H for bug-gnu-emacs@gnu.org; Tue, 29 Dec 2020 14:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Dec 2020 19:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45428 X-GNU-PR-Package: emacs Original-Received: via spool by 45428-submit@debbugs.gnu.org id=B45428.160927078926409 (code B ref 45428); Tue, 29 Dec 2020 19:40:01 +0000 Original-Received: (at 45428) by debbugs.gnu.org; 29 Dec 2020 19:39:49 +0000 Original-Received: from localhost ([127.0.0.1]:40238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuKqT-0006rt-3z for submit@debbugs.gnu.org; Tue, 29 Dec 2020 14:39:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuKqP-0006rf-Pb for 45428@debbugs.gnu.org; Tue, 29 Dec 2020 14:39:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37029) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuKqI-0003ax-3W; Tue, 29 Dec 2020 14:39:38 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4413 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kuKqH-0002aV-JC; Tue, 29 Dec 2020 14:39:37 -0500 In-Reply-To: (message from Drew Adams on Tue, 29 Dec 2020 10:27:11 -0800 (PST)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196965 Archived-At: > Date: Tue, 29 Dec 2020 10:27:11 -0800 (PST) > From: Drew Adams > Cc: larsi@gnus.org, stefan@marxist.se, triska@metalevel.at, > 45428@debbugs.gnu.org > > Indeed. I thought that's what you might say. Yes, > that description is fine. But I hope you'll recognize > that the (quote (quote '(...))) example is a gotcha, > especially given that the "Invalid face reference: > quote" message is shown in *Messages* only after some > action provokes redisplay, and it often is not seen > in the echo area. Without your having piped up here > to say "Please look in *Messages*" I wouldn't have > noticed it, for example. We cannot signal an error from redisplay, so all we can do is log the error in *Messages*. We do that with any error inside redisplay, there's nothing new here. > Better still perhaps, instead of trying to address > the specific `quote' gotcha (which is particularly > misleading), the "Invalid face..." interaction could > perhaps be improved. If that msg were (1) more > visible and immediate and (2) said more about what > is invalid (even just pointing out that here `quote' > is taken as a face name or whatever), that might help. Patches to make the diagnostics in this case are welcome. The code that implements the face merging and deals with these forms is quite simple, and doesn't really know what's wrong with the face in this case, it just knows it's invalid.