From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Wed, 17 Feb 2021 17:18:45 +0200 Message-ID: <83wnv67mei.fsf@gnu.org> References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31212"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 17 16:19:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCObv-0007yF-8q for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Feb 2021 16:19:27 +0100 Original-Received: from localhost ([::1]:34866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCObu-0003Vq-5k for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Feb 2021 10:19:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCObW-0003Vi-UO for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2021 10:19:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCObW-0001GD-57 for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2021 10:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCObW-0004Vv-1G for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2021 10:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Feb 2021 15:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161357512417323 (code B ref 43725); Wed, 17 Feb 2021 15:19:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 17 Feb 2021 15:18:44 +0000 Original-Received: from localhost ([127.0.0.1]:44679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCObE-0004VL-3I for submit@debbugs.gnu.org; Wed, 17 Feb 2021 10:18:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCObC-0004V4-9n for 43725@debbugs.gnu.org; Wed, 17 Feb 2021 10:18:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48309) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCOb6-00018I-Gf; Wed, 17 Feb 2021 10:18:36 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2664 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lCOb5-00017d-Ss; Wed, 17 Feb 2021 10:18:36 -0500 In-Reply-To: (message from Andrea Corallo on Tue, 16 Feb 2021 21:13:07 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200197 Archived-At: > From: Andrea Corallo > Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org > Date: Tue, 16 Feb 2021 21:13:07 +0000 > > Addressing some easy part of the review to close the day. Thanks. > > Likewise, this is unsafe because a fixnum can be larger than INT_MAX: > > > > + if (!FIXNUMP (idx)) > > + xsignal1 (Qnative_ice, > > + build_string ("inconsistent data relocation container")); > > + reloc.idx = gcc_jit_context_new_rvalue_from_int (comp.ctxt, > > + comp.ptrdiff_type, > > + XFIXNUM (idx)); <<<<<<<< > > > > (There are several more calls with the same problem.) > > Should we never trust in C a value coming from a Lisp_Object even if is > supposed to be constructed on purpose? We can trust that if we indeed make the value explicitly, but if there's at least a tiny chance to get a value that's too large, at least an assertion would be a good idea.