From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46915: [PATCH] Remove unecessary change_req arg from overlays_at() Date: Sun, 07 Mar 2021 08:05:31 +0200 Message-ID: <83wnujts5w.fsf@gnu.org> References: <835z27jagi.fsf@gnu.org> <87r1kuadow.fsf@mdeb> <83r1kuzk6a.fsf@gnu.org> <87a6rfn83h.fsf@mdeb> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14219"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46915@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 07 07:06:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lImYS-0003bg-TO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 07:06:16 +0100 Original-Received: from localhost ([::1]:44228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lImYS-0008HW-0A for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 01:06:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lImYF-0008HM-Sx for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 01:06:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lImYE-00032u-Ar for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 01:06:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lImYE-0000mP-0r for bug-gnu-emacs@gnu.org; Sun, 07 Mar 2021 01:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Mar 2021 06:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46915-submit@debbugs.gnu.org id=B46915.16150971492979 (code B ref 46915); Sun, 07 Mar 2021 06:06:01 +0000 Original-Received: (at 46915) by debbugs.gnu.org; 7 Mar 2021 06:05:49 +0000 Original-Received: from localhost ([127.0.0.1]:38764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lImY0-0000ly-Nj for submit@debbugs.gnu.org; Sun, 07 Mar 2021 01:05:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lImXz-0000ll-11 for 46915@debbugs.gnu.org; Sun, 07 Mar 2021 01:05:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53406) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lImXt-0002yA-AM; Sun, 07 Mar 2021 01:05:41 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2673 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lImXs-0008Db-Tn; Sun, 07 Mar 2021 01:05:41 -0500 In-Reply-To: <87a6rfn83h.fsf@mdeb> (message from Matt Armstrong on Sat, 06 Mar 2021 16:03:14 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201718 Archived-At: > From: Matt Armstrong > Cc: 46915@debbugs.gnu.org > Date: Sat, 06 Mar 2021 16:03:14 -0800 > > > So I urge you to continue the work on the noverlay branch, and if that > > branch will come with this and other changes in the internal APIs, > > that's fine by me. My problem is only with installing API changes > > right now, when we are not at all sure yet the overlays redesign will > > indeed land any time soon. > > > > OK? > > I'm happy to defer this for now. Thank you. And thanks for your interest to this area in Emacs, whose reimplementation is long overdue. > I might come back and ask that this change go in before doing actual > surgery on the overlay implementation. In the past, on other projects, > I have found it worthwhile to first simplify APIs, and assert various > assumed invariants more rigidly, and let those changes bake for a while, > before beginning to modify implementations. But, I would agree that > those kinds of changes are best done according to some sort of generally > agreed upon plan, not just ad hoc. If you do the work on a feature branch, the order is entirely up to you. What I'd like to avoid is to have such changes land on master without being sure they will be reasonably closely followed by "the real thing". We had our share of disappointments with such changes in the past, and I'd like to avoid repeating such mistakes.