From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29713: 26.0; Provide completion for `make-frame-on-display' Date: Thu, 18 Mar 2021 17:50:01 +0200 Message-ID: <83wnu4foly.fsf@gnu.org> References: <87y310wkzb.fsf@mouse.gnus.org> <875zo4v1t1.fsf@mail.linkov.net> <87eegcwofb.fsf@tcd.ie> <835z1oh6l3.fsf@gnu.org> <874kh8mrb4.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3280"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 29713@debbugs.gnu.org, larsi@gnus.org, juri@linkov.net To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 18 16:53:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMuxF-0000Xt-BU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 16:52:57 +0100 Original-Received: from localhost ([::1]:43642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMuxE-0006Vd-Ap for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Mar 2021 11:52:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMuvP-0004y6-R9 for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 11:51:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36259) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMuvO-0003Gm-9b for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 11:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMuvO-0001a8-8H for bug-gnu-emacs@gnu.org; Thu, 18 Mar 2021 11:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Mar 2021 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29713 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 29713-submit@debbugs.gnu.org id=B29713.16160826136016 (code B ref 29713); Thu, 18 Mar 2021 15:51:02 +0000 Original-Received: (at 29713) by debbugs.gnu.org; 18 Mar 2021 15:50:13 +0000 Original-Received: from localhost ([127.0.0.1]:47805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuua-0001Yx-Uy for submit@debbugs.gnu.org; Thu, 18 Mar 2021 11:50:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMuuZ-0001YR-0Z for 29713@debbugs.gnu.org; Thu, 18 Mar 2021 11:50:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57899) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMuuS-0002hG-Ng; Thu, 18 Mar 2021 11:50:04 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4229 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lMuuP-0004pS-2Y; Thu, 18 Mar 2021 11:50:02 -0400 In-Reply-To: <874kh8mrb4.fsf@tcd.ie> (contovob@tcd.ie) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202615 Archived-At: > From: "Basil L. Contovounesios" > Cc: juri@linkov.net, 29713@debbugs.gnu.org, larsi@gnus.org > Date: Thu, 18 Mar 2021 15:09:51 +0000 > > > In a GUI session, the function is always available, although the list > > it returns might disappoint w32 users... > > Is there a better option on w32? The w32 build supports only one display. > >> (interactive (list (completing-read > >> (format "Make frame on display: ") > >> (if (fboundp 'x-display-list) > >> (x-display-list) > >> (user-error "No connected displays found"))))) > >> > >> This will barf before make-frame is called, and pacifies the > >> byte-compiler warning about x-display-list not being known. > >> > >> (interactive (list (completing-read > >> (format "Make frame on display: ") > >> (and (fboundp 'x-display-list) > >> (x-display-list))))) > >> > >> This will barf when make-frame is called, with e.g.: > >> > >> make-frame: Don’t know how to interpret display "" > >> make-frame: Don’t know how to interpret display ":0" > >> > >> And also pacifies the warning. > >> > >> Any preferences or alternative suggestions? > > > > make-frame-on-display should signal an error in non-GUI builds. > > Agreed, but are you sanctioning the first option above, or either > option, so long as some error is signalled? I'm not sure. The wording of the messages sounds not the best to me. It should ideally say something like "This Emacs build doesn't support X displays".