From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47574: 'match' face is too bright Date: Sat, 03 Apr 2021 09:39:43 +0300 Message-ID: <83wntjeus0.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30362"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47574@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 03 08:41:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSZy1-0007nh-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Apr 2021 08:41:09 +0200 Original-Received: from localhost ([::1]:36090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSZy0-0003lZ-Ci for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Apr 2021 02:41:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSZxu-0003lT-Kk for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2021 02:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSZxu-0001oq-Dy for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2021 02:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSZxu-000300-BH for bug-gnu-emacs@gnu.org; Sat, 03 Apr 2021 02:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Apr 2021 06:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47574 X-GNU-PR-Package: emacs Original-Received: via spool by 47574-submit@debbugs.gnu.org id=B47574.161743200211447 (code B ref 47574); Sat, 03 Apr 2021 06:41:02 +0000 Original-Received: (at 47574) by debbugs.gnu.org; 3 Apr 2021 06:40:02 +0000 Original-Received: from localhost ([127.0.0.1]:33187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSZwv-0002yZ-OV for submit@debbugs.gnu.org; Sat, 03 Apr 2021 02:40:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSZwt-0002y2-Vh for 47574@debbugs.gnu.org; Sat, 03 Apr 2021 02:40:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49903) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSZwo-00017U-AI; Sat, 03 Apr 2021 02:39:54 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1665 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lSZwn-0004MU-Kw; Sat, 03 Apr 2021 02:39:54 -0400 In-Reply-To: (message from Dmitry Gutov on Sat, 3 Apr 2021 02:42:43 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203486 Archived-At: > From: Dmitry Gutov > Date: Sat, 3 Apr 2021 02:42:43 +0300 > > Split off from the discussion in bug#47012. > > I think the current "yellow1" is too bright and in-your-face. > > It handles its goal (having the matched substrings noticed) admirably, > but perhaps too well, because we normally don't want to reach each > match, but rather the contents of the line around it. So I think it's > not productive putting so much visual attention on it. If someone wants to see the lines without the match standing out, they can customize list-matching-lines-face to nil. So this use case is already covered. FTR, I do want to see the match itself, so this face does its job for me very well. > Juri suggested #ffff88, and it seems good to me. Both readable and > noticeable, yet not too bright. > > My original suggestions were "lemon chiffon" (seems ideally subdued to > me, but it would be a drastic change), "khaki1" or "light goldenrod". If we change the face's colors, we should make sure the new colors look well on both light and dark backgrounds.