From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48137: 27.2; `package-install-file' fails when loading a package file with DOS line endings Date: Thu, 06 May 2021 11:12:26 +0300 Message-ID: <83wnsce0wl.fsf@gnu.org> References: <834kfmabvs.fsf@gnu.org> <83tunj651i.fsf@gnu.org> <83lf8u68bu.fsf@gnu.org> <83mtta4gtf.fsf@gnu.org> <83fsz24f2x.fsf@gnu.org> <83v97x2xum.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3995"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48137@debbugs.gnu.org, monnier@iro.umontreal.ca To: Ioannis Kappas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 10:13:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZ8I-0000uH-RJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 10:13:18 +0200 Original-Received: from localhost ([::1]:36546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leZ8H-0004XH-TI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 04:13:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leZ82-0004Va-Qi for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leZ82-0003Sr-Fl for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leZ82-0002Xq-B6 for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 08:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48137 X-GNU-PR-Package: emacs Original-Received: via spool by 48137-submit@debbugs.gnu.org id=B48137.16202887749776 (code B ref 48137); Thu, 06 May 2021 08:13:02 +0000 Original-Received: (at 48137) by debbugs.gnu.org; 6 May 2021 08:12:54 +0000 Original-Received: from localhost ([127.0.0.1]:36984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZ7m-0002Xa-Ev for submit@debbugs.gnu.org; Thu, 06 May 2021 04:12:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZ7j-0002XU-P1 for 48137@debbugs.gnu.org; Thu, 06 May 2021 04:12:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49934) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leZ7e-0003Cn-JX; Thu, 06 May 2021 04:12:38 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3178 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leZ7c-0001Y4-Vh; Thu, 06 May 2021 04:12:37 -0400 In-Reply-To: (message from Ioannis Kappas on Thu, 6 May 2021 07:55:52 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205766 Archived-At: > From: Ioannis Kappas > Date: Thu, 6 May 2021 07:55:52 +0100 > Cc: Stefan Monnier , 48137@debbugs.gnu.org > > > My idea was to read the file literally, without decoding, then parse > > the package headers from that. > > I suppose you mean something along the other option below? It could be, but as I said up-thread, this specific change allows a lone \r to be taken as an end of line, which I think is wrong. We should only support a single \n or a \r\n pair. See this comment I made back then: > > > - "[^\n]+" "[^$\n]+"))) > > > + "[^\n\r]+" "[^$\n\r]+"))) > > > > This is better, but IMO the code should be rewritten not to allow a > > lone CR character, only either a lone LF or the CRLF pair. Thanks.