unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Konstantin Shabanov <mail@etehtsea.me>
Cc: 48354-done@debbugs.gnu.org
Subject: bug#48354: [PATCH] Fix compat with latest mingw64-headers
Date: Tue, 11 May 2021 18:46:50 +0300	[thread overview]
Message-ID: <83wns546j9.fsf@gnu.org> (raw)
In-Reply-To: <RxCtHCQesKsK0kOcsDNmyPWncHlbl8it4xJxGJqmRJ5as_97_3oG7EiAZEtnBKiJInleI2KJz7yPh1gQ_CU6xMqJt0OpqRPL_ShNnWCw-J4=@etehtsea.me> (message from Konstantin Shabanov on Tue, 11 May 2021 12:59:47 +0000)

> Date: Tue, 11 May 2021 12:59:47 +0000
> From: Konstantin Shabanov <mail@etehtsea.me>
> 
> 
> [1:text/plain Hide]
> 
> This commit to mingw-w64 broke compatibility with emacs-head because of the OS_NT conflict:
> 
>     In file included from w32image.c:32:
>     w32common.h:45:3: error: expected identifier before numeric constant
>        45 |   OS_NT
>           |   ^~~~~
> 
> https://sourceforge.net/p/mingw-w64/mingw-w64/ci/dc7ef298837d4581200a3bed660aed36818c1b00/
> 
> The series of patches in attachments should fix the issue:
> - the first one should cause the build to fail in the future instead of silent overriding definition;
> - the second patch renames OS_9X to conform mingw-w64 naming;
> - the third actually fixes build failure (preserving backward compatibility);

Thanks, this is already fixed since 2 days ago on the emacs-27 branch,
soon to be merged to master.





      reply	other threads:[~2021-05-11 15:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 12:59 bug#48354: [PATCH] Fix compat with latest mingw64-headers Konstantin Shabanov
2021-05-11 15:46 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wns546j9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48354-done@debbugs.gnu.org \
    --cc=mail@etehtsea.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).