From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44950: 28.0.50; 24-bit colors not used in terminal with emacsclient Date: Mon, 31 May 2021 19:19:17 +0300 Message-ID: <83wnre27wa.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1768"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tastytea@tastytea.de, 44950@debbugs.gnu.org To: Tim Ruffing Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 31 18:22:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnkgG-0000EC-DW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 18:22:20 +0200 Original-Received: from localhost ([::1]:60630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnkgF-0002Xw-ER for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 May 2021 12:22:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45202) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnke2-0000IS-2n for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 12:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lnke1-0000hR-Po for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 12:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lnke1-0006pS-KQ for bug-gnu-emacs@gnu.org; Mon, 31 May 2021 12:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 May 2021 16:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44950 X-GNU-PR-Package: emacs Original-Received: via spool by 44950-submit@debbugs.gnu.org id=B44950.162247797626214 (code B ref 44950); Mon, 31 May 2021 16:20:01 +0000 Original-Received: (at 44950) by debbugs.gnu.org; 31 May 2021 16:19:36 +0000 Original-Received: from localhost ([127.0.0.1]:34687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnkdc-0006oj-JV for submit@debbugs.gnu.org; Mon, 31 May 2021 12:19:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnkdZ-0006oW-RT for 44950@debbugs.gnu.org; Mon, 31 May 2021 12:19:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50428) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnkdT-0000SA-1b; Mon, 31 May 2021 12:19:27 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4765 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnkdS-0000ek-Ku; Mon, 31 May 2021 12:19:26 -0400 In-Reply-To: (message from Tim Ruffing on Mon, 31 May 2021 16:06:55 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207710 Archived-At: > From: Tim Ruffing > Cc: 44950@debbugs.gnu.org > Date: Mon, 31 May 2021 16:06:55 +0200 > > I think what tastytea is saying is that when emacs checks the env > variable COLORTERM, it uses the environment of the server and not the > one of emacsclient. And yes, that's just a bug. emacsclient should read > that variable and pass it to server. But this requires new code because > it breaks with the pattern of using terminfo to detect term support. > > So the terminfo detection is currently more reliable. Would you be > willing to accept something like the attached patch? This will improve > detection without relying on COLORTERM, which should make the situation > already much better. Tc is in the terminfo of many terminals, see > https://gist.github.com/XVilka/8346728 . That sounds like a kludge to me, of which we already have quite a few there (the COLORTERM thing is already a kludge). Do we really have to add one more trick, just to paper over bad terminfo data? Why don't these terminals get their act together and fix their terminfo?