unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: 48740@debbugs.gnu.org
Subject: bug#48740: 28.0.50; Composition text property is not always honoured
Date: Tue, 01 Jun 2021 18:25:17 +0300	[thread overview]
Message-ID: <83wnrdzjxe.fsf@gnu.org> (raw)
In-Reply-To: <878s3tbqvx.fsf@localhost> (message from Ihor Radchenko on Tue, 01 Jun 2021 22:28:50 +0800)

> From: Ihor Radchenko <yantar92@gmail.com>
> CC: 48740@debbugs.gnu.org
> Date: Tue, 01 Jun 2021 22:28:50 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> The two intervals are there because other properties in the list are
> >> not same, as I understand.
> >
> > Exactly.  And that cannot work with the composition property.
> 
> Again, I feel that I miss something. Consider the following test case:
> 
> (switch-to-buffer "test")
> (insert "asdasd")
> (compose-region (point-min) (point-max) '(?a (bl . tl) ?| (bl . tl) ?b))
> (put-text-property 1 3 'test 1)
> (put-text-property 3 6 'test 2)
> (buffer-string)
> 
> The output is
> 
> #("asdasd" 0 2 (composition (43 6 [97 72 124 72 98]) test 1) 2 5 (composition (43 6 [97 72 124 72 98]) test 2) 5 6 (composition (43 6 [97 72 124 72 98])))
> 
> Composition works fine here despite spanning over multiple intervals.
> Again, I feel that I miss something in your explanation.

We are mis-communicating.  You already stated correctly the reason for
the problem:

> The only possibility I can think about is that compositions in the two
> intervals are 'eq at step 6, but only 'equal at step 8. (How on Earth
> can one debug this???)

More accurately, it isn't the intervals that must be 'eq', it's the
values of the 'composition' property in the 2 adjacent intervals.  In
Step 6 (and in the example above) they are 'eq', in Step 8 they
aren't.  All the rest was my failed attempt to correct your inaccurate
description of what happens; forget about that if you want.

I don't know why the values of the 'composition' property become not
'eq'; perhaps some code does a copy-sequence or something?  Presumably
if you take a good look at what happens in org-agenda-redo-all and its
subroutines, you will find that code.  In general, when you are
dealing with static compositions, I'd suggest not to break the
composed region into several separate intervals with different
property lists: it's dangerous, as you see.





  reply	other threads:[~2021-06-01 15:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-30  7:35 bug#48740: 28.0.50; Composition text property is not always honoured Ihor Radchenko
2021-05-30 11:10 ` Eli Zaretskii
2021-05-30 13:08   ` Ihor Radchenko
2021-05-30 13:52     ` Eli Zaretskii
2021-05-30 15:13       ` Ihor Radchenko
2021-05-30 15:58         ` Eli Zaretskii
2021-05-31 13:00           ` Ihor Radchenko
2021-05-31 14:32             ` Eli Zaretskii
2021-06-01 14:28               ` Ihor Radchenko
2021-06-01 15:25                 ` Eli Zaretskii [this message]
2021-06-01 16:25                   ` Eli Zaretskii
2021-06-20 11:24                   ` Ihor Radchenko
2021-06-20 11:53                     ` Eli Zaretskii
2021-06-20 13:16                       ` Ihor Radchenko
2021-06-21 12:18                         ` Eli Zaretskii
2021-06-24 14:35                           ` Ihor Radchenko
2021-06-24 16:06                             ` Eli Zaretskii
2021-10-24  7:42                               ` Stefan Kangas
2021-10-24 12:04                                 ` Eli Zaretskii
2021-10-24 12:27                                   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wnrdzjxe.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48740@debbugs.gnu.org \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).