From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49261: Segfault during loadup Date: Mon, 12 Jul 2021 15:07:32 +0300 Message-ID: <83wnpvag6z.fsf@gnu.org> References: <87o8bn7bie.fsf@gnus.org> <87zgv6vuon.fsf@gmx.de> <837di9lwbm.fsf@gnu.org> <87a6n5vuu4.fsf@gnus.org> <8735sqnmei.fsf@gnus.org> <87zguyf4ht.fsf@gmx.de> <87pmvum54p.fsf@gnus.org> <87v95mf2lj.fsf@gmx.de> <87pmvt3ob1.fsf@gnus.org> <83r1g9evoy.fsf@gnu.org> <83pmvtevgg.fsf@gnu.org> <87czrt3mj4.fsf@gnus.org> <878s2h3m1d.fsf@gnus.org> <874kd53lnl.fsf@gnus.org> <87zgux26ab.fsf@gnus.org> <87pmvt25uq.fsf@gnus.org> <87lf6h2294.fsf@gnus.org> <87h7h51x9y.fsf_-_@gnus.org> <83bl79b17n.fsf@gnu.org> <835yxgc1pm.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33386"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 49261@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 12 14:08:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2ujH-0008YX-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Jul 2021 14:08:07 +0200 Original-Received: from localhost ([::1]:41934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2ujG-00061S-Ux for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Jul 2021 08:08:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2ujC-00061G-1X for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2021 08:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2ujB-0007oF-QI for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2021 08:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m2ujB-00070l-MG for bug-gnu-emacs@gnu.org; Mon, 12 Jul 2021 08:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Jul 2021 12:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49261 X-GNU-PR-Package: emacs Original-Received: via spool by 49261-submit@debbugs.gnu.org id=B49261.162609166926932 (code B ref 49261); Mon, 12 Jul 2021 12:08:01 +0000 Original-Received: (at 49261) by debbugs.gnu.org; 12 Jul 2021 12:07:49 +0000 Original-Received: from localhost ([127.0.0.1]:36683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2uiy-00070K-NR for submit@debbugs.gnu.org; Mon, 12 Jul 2021 08:07:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2uix-000708-Ix for 49261@debbugs.gnu.org; Mon, 12 Jul 2021 08:07:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48740) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2uir-0007ef-A4; Mon, 12 Jul 2021 08:07:41 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1520 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2uiq-0000z3-UJ; Mon, 12 Jul 2021 08:07:41 -0400 In-Reply-To: (message from Paul Eggert on Mon, 12 Jul 2021 00:16:07 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209817 Archived-At: > Cc: larsi@gnus.org, 49261@debbugs.gnu.org > From: Paul Eggert > Date: Mon, 12 Jul 2021 00:16:07 -0700 > > >> lisp.h:251:18: warning: unsigned conversion from 'long long int' to 'uintptr_t' {aka 'unsigned int'} changes value from '2305843009213693951' to '4294967295' [-Woverflow] > >> 251 | # define VALMASK (USE_LSB_TAG ? - (1 << GCTYPEBITS) : VAL_MAX) > >> | ^ > >> alloc.c:4767:24: note: in expansion of macro 'VALMASK' > >> 4767 | uintptr_t mask = VALMASK; > >> | ^~~~~~~ > > I tried to fix this on master, please take a look. > > Yes that GCC warning was bogus, and your pacification of GCC is valid Hmm... is it really a bogus warning? VALMASK is a 64-bit value, and uintptr_t is 32-bit wide. > now that we no longer tag the MSB of pointers. Still, there should be a > simpler way to pacify GCC so I installed a further fix that I hope does > that (see first attached patch). This fix simply uses a cast (uintptr_t) > VALMASK to pacify GCC; if GCC issues a bogus warning even for that cast, > we could substitute (uintptr_t) (VALMASK & UINTPTR_MAX) though this is > starting to get a little ridiculous. Your fix compiles cleanly, thanks.