From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49127: Performance degradation in encode_coding_object Date: Tue, 17 Aug 2021 20:16:29 +0300 Message-ID: <83wnok56vm.fsf@gnu.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25517"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 17 19:17:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mG2i5-0006OW-Ty for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Aug 2021 19:17:09 +0200 Original-Received: from localhost ([::1]:39960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mG2i4-0008Nf-FL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Aug 2021 13:17:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mG2hy-0008N8-GF for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 13:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mG2hy-00006D-8l for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 13:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mG2hx-0004oJ-S9 for bug-gnu-emacs@gnu.org; Tue, 17 Aug 2021 13:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Aug 2021 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49127 X-GNU-PR-Package: emacs Original-Received: via spool by 49127-submit@debbugs.gnu.org id=B49127.162922059918455 (code B ref 49127); Tue, 17 Aug 2021 17:17:01 +0000 Original-Received: (at 49127) by debbugs.gnu.org; 17 Aug 2021 17:16:39 +0000 Original-Received: from localhost ([127.0.0.1]:53994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG2hb-0004nb-7Z for submit@debbugs.gnu.org; Tue, 17 Aug 2021 13:16:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG2hZ-0004nM-0h for 49127@debbugs.gnu.org; Tue, 17 Aug 2021 13:16:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38528) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mG2hT-00087C-Q1; Tue, 17 Aug 2021 13:16:31 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3194 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mG2hT-0002Ti-Cz; Tue, 17 Aug 2021 13:16:31 -0400 In-Reply-To: <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 17 Aug 2021 18:07:10 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212097 Archived-At: > From: Mattias Engdegård > Date: Tue, 17 Aug 2021 18:07:10 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > This business makes me wonder if there are more cases where the linear marker list causes bad performance. Probably not very often but it's not unreasonable for a mode to have many data structures with many (live) markers into the text, and that would lead to text changes going from O(1) to O(text size). In any case, not anything to worry about right now. It's a problem to have many markers in a buffer. Not only for code that searches them linearly, but also for stuff like converting between character and byte positions, something that we do a lot in the most inner loops of our code. Lisp programs that produce gobs of markers should be ideally redesigned not to do so. Unless we change the way we store markers to make that a non-issue.