From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Tue, 19 Oct 2021 20:37:52 +0300 Message-ID: <83wnm8c3v3.fsf@gnu.org> References: <87bl4jvudm.fsf@gnus.org> <837dehp248.fsf@gnu.org> <87czo96shw.fsf@gnus.org> <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <87v91tfzrw.fsf@gnus.org> <87r1chfz80.fsf@gnus.org> <83r1chcjof.fsf@gnu.org> <87mtn5fc9s.fsf@gnus.org> <83bl3lchrp.fsf@gnu.org> <87ee8hfajg.fsf@gnus.org> <838rypc98p.fsf@gnu.org> <87h7ddc8iy.fsf@gnus.org> <831r4hc7ta.fsf@gnu.org> <878rypc7e8.fsf@gnus.org> <83zgr5asej.fsf@gnu.org> <8735oxc51n.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 19:38:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mct4k-0000wI-MF for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 19:38:58 +0200 Original-Received: from localhost ([::1]:60372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mct4j-00043M-BN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 13:38:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58950) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mct3r-00041L-2N for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 13:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40363) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mct3q-0000BC-CV for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 13:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mct3q-0007WV-2l for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 13:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163466507828909 (code B ref 50752); Tue, 19 Oct 2021 17:38:02 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 19 Oct 2021 17:37:58 +0000 Original-Received: from localhost ([127.0.0.1]:51909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mct3m-0007WD-91 for submit@debbugs.gnu.org; Tue, 19 Oct 2021 13:37:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mct3k-0007W0-Uq for 50752@debbugs.gnu.org; Tue, 19 Oct 2021 13:37:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32946) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mct3f-0008Tb-5h; Tue, 19 Oct 2021 13:37:51 -0400 Original-Received: from [87.69.77.57] (port=4675 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mct3e-00072B-Ps; Tue, 19 Oct 2021 13:37:51 -0400 In-Reply-To: <8735oxc51n.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 19 Oct 2021 19:12:20 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217587 Archived-At: > From: Lars Ingebrigtsen > Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org > Date: Tue, 19 Oct 2021 19:12:20 +0200 > > Eli Zaretskii writes: > > > I think we can leave the behavior with raw bytes as it is, and still > > document this use case as being meant for ASCII conversions, leaving > > the subtle case of raw bytes ... subtle. > > Yup. > > The following patch seems to do the trick, and should be conservative > enough for emacs-28, I think. I wouldn't start such experiments on the release branch. It's not an urgent problem. > +static int > +ascii_casify_character (bool downcase, int c) > +{ > + Lisp_Object cased = CHAR_TABLE_REF (downcase? > + uniprop_table (Qlowercase) : > + uniprop_table (Quppercase), > + c); > + return FIXNATP (cased) ? XFIXNAT (cased) : c; > +} uniprop_table is somewhat expensive, and is definitely an overkill for converting pure ASCII characters. Why not just set/reset the 0x20 bit?