From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52440: 28.0.50; [PATCH] Quis custodiet ipsos custodes (sqlite3) Date: Sun, 12 Dec 2021 14:01:23 +0200 Message-ID: <83wnkanib0.fsf@gnu.org> References: <87wnkazv3i.fsf@dick> <87r1aie4hr.fsf@gnus.org> <83ee6ip8ej.fsf@gnu.org> <87lf0q6otw.fsf@dick> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52440@debbugs.gnu.org, larsi@gnus.org To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 13:02:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwNYR-0009el-0C for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 13:02:11 +0100 Original-Received: from localhost ([::1]:54844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwNYO-0000dk-PF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 07:02:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNYI-0000dc-Fa for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 07:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwNYI-0004Y2-63 for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 07:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwNYH-0007pD-Vr for bug-gnu-emacs@gnu.org; Sun, 12 Dec 2021 07:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 12:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch wontfix Original-Received: via spool by 52440-submit@debbugs.gnu.org id=B52440.163931050029038 (code B ref 52440); Sun, 12 Dec 2021 12:02:01 +0000 Original-Received: (at 52440) by debbugs.gnu.org; 12 Dec 2021 12:01:40 +0000 Original-Received: from localhost ([127.0.0.1]:50817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNXv-0007Xu-G9 for submit@debbugs.gnu.org; Sun, 12 Dec 2021 07:01:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwNXu-0007TH-9s for 52440@debbugs.gnu.org; Sun, 12 Dec 2021 07:01:38 -0500 Original-Received: from [2001:470:142:3::e] (port=57870 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNXo-0004Um-VL; Sun, 12 Dec 2021 07:01:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Bi32lkXXWX5aOMfMGy/sEgGyiOKr27tu0Yt0iNQiDDs=; b=kExMrekwucuV +hgpBkKsH3+aJy1Ey+oADkkMFSLQkvqMBWWjXHwHPI6yvzl//dKx7tgTtmHqDdwjn+OkispkMZRoT i4KDcHs+SRdwIf3RHo4bFTHePwm5S8OMJWmDWfSgN68Z3aI30u75RgkZ5mggQa+E26ua1nbpgP+XH gRneO1aJLtz3o61rr6tPQw6MnoHALe+ip0WOAPmofAB4j6pFWcn1LsMqf+kg6QKQEUw2s93jVHsfh lTR7tXUD6rQ8ilodkNqfa+UJQu11eNPreVU7Q3TD10NUUJ1onZcV46pZMl/FtqP2ySMusAr7hGESm ILf1ArrOIyyxdEFcrzcQ0Q==; Original-Received: from [87.69.77.57] (port=2410 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwNXo-00048x-OX; Sun, 12 Dec 2021 07:01:33 -0500 In-Reply-To: <87lf0q6otw.fsf@dick> (message from dick on Sun, 12 Dec 2021 06:32:27 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222216 Archived-At: > From: dick > Cc: Lars Ingebrigtsen , 52440@debbugs.gnu.org > Date: Sun, 12 Dec 2021 06:32:27 -0500 > > EZ> The amount of sqlite stuff in lisp.h is quite small... So I tend > EZ> to think a separate header is overkill. > > Thinking about this in terms of number of bytes added to lisp.h is the > wrong way to think about it. If that's the only aspect, perhaps. But it isn't the only aspect: there are others, which I mentioned, and you elided. Together with them, the size is relevant to decide between the alternatives. > I agree that Lisp_Process, while important, doesn't belong in lisp.h. > That something as ancillary, third-party, and controversial as > Lisp_Sqlite does get into lisp.h is a testimony about its author. We are not dogmatic about this stuff. This is C, not C++, so what goes into what header is not subject to dogma. And this isn't the case that just files dealing with sqlite will include this header: every source file that deals with Lisp objects will need it, so at least conceptually it belongs to lisp.h. Triggering unnecessary rebuilds is an annoyance during development, so it's no less important than purity of the headers.