From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54329: 28.0.91; custom-prompt-customize-unsaved-options does not return nil Date: Thu, 10 Mar 2022 20:29:38 +0200 Message-ID: <83wnh1d5kd.fsf@gnu.org> References: <878rthhjae.fsf@whxvd.name> <835yolentu.fsf@gnu.org> <87v8wlg05i.fsf@whxvd.name> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25534"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54329@debbugs.gnu.org To: Sebastian Miele Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 10 19:30:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSNYC-0006QX-MO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Mar 2022 19:30:13 +0100 Original-Received: from localhost ([::1]:44100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSNYB-0007UR-2v for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Mar 2022 13:30:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSNY3-0007U1-AN for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2022 13:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSNY2-00068J-VY for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2022 13:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSNY2-0003GP-Pu for bug-gnu-emacs@gnu.org; Thu, 10 Mar 2022 13:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Mar 2022 18:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54329 X-GNU-PR-Package: emacs Original-Received: via spool by 54329-submit@debbugs.gnu.org id=B54329.164693698812499 (code B ref 54329); Thu, 10 Mar 2022 18:30:02 +0000 Original-Received: (at 54329) by debbugs.gnu.org; 10 Mar 2022 18:29:48 +0000 Original-Received: from localhost ([127.0.0.1]:35484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSNXn-0003FW-TE for submit@debbugs.gnu.org; Thu, 10 Mar 2022 13:29:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSNXl-0003FK-S2 for 54329@debbugs.gnu.org; Thu, 10 Mar 2022 13:29:47 -0500 Original-Received: from [2001:470:142:3::e] (port=32802 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSNXf-00062Y-Vf; Thu, 10 Mar 2022 13:29:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KEouRAakDqynvq0fmOr/Roo9fQf+P9sWUiRFEPwtpVU=; b=paRZ5zMrE5GjRn+rLCWx Zr147FaCp1hS+bQSukinv7dcwsicUpTCY6DZ1pkSWcZo1BCNw6IIjQqlhu22xI3/JJw2Spu4j4Pc/ dfTa5Inu0dBU68XhsCk+/Gol5aaa3XXk4jHXBKqxA55oT629DYUp8BsrkbYzp03KOZPweA/+xwGOw V48kzVsGZ9wWRdPDVbkhLeCoakqK2Di70tNxgNWqaozObptcgdKu+nkogVIsjHJtyuzyqf1+nrccJ gHqyxeV7x3Cd1DLJopZGC4Z1t4AF2pcAN8r5ERKBjVZT7i0WDe1eiARSTsO0F9Iwz1dOQ2Z2KbUu4 Th1SsYNsEmgY0g==; Original-Received: from [87.69.77.57] (port=1590 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSNXf-0007L8-BM; Thu, 10 Mar 2022 13:29:39 -0500 In-Reply-To: <87v8wlg05i.fsf@whxvd.name> (message from Sebastian Miele on Thu, 10 Mar 2022 18:17:02 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228202 Archived-At: > From: Sebastian Miele > Cc: 54329@debbugs.gnu.org > Date: Thu, 10 Mar 2022 18:17:02 +0100 > > The reason that the behavior of > ‘custom-prompt-customize-unsaved-options’ changed from version 27.2 to > 28 almost certainly is the following: > > ‘custom-prompt-customize-unsaved-options’ calls ‘customize-unsaved’ > which ends with call to ‘custom-buffer-create’. The definition of > ‘custom-buffer-create’ changed from Emacs 27.2 to Emacs 28. In Emacs > 27.2 it probably always returned non-nil. In Emacs 28 it always > returns nil. > > However, the (and ...) form in > ‘custom-prompt-customize-unsaved-options’ depends on > ‘customize-unsaved’ to always return non-nil in order to be correct. > > ‘custom-prompt-customize-unsaved-options’ always had the bug reported > here. It just did not manifest before ‘custom-buffer-create’ was > changed from Emacs 27.2 to Emacs 28. Thanks, this was the information I missed. I installed a minor variation of your changes on the emacs-28 branch. Please take a look.