From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55900: [PATCH] Hierarchy =?UTF-8?Q?=E2=80=93?= Defer the Computation of Children Date: Sat, 11 Jun 2022 11:21:52 +0300 Message-ID: <83wndny5i7.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39033"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55900@debbugs.gnu.org To: "Wamm K. D." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 11 10:23:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzwOx-0009uc-QY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Jun 2022 10:23:23 +0200 Original-Received: from localhost ([::1]:54596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzwOw-00036y-R6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Jun 2022 04:23:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzwOc-00035g-DY for bug-gnu-emacs@gnu.org; Sat, 11 Jun 2022 04:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzwOc-00051Z-5A for bug-gnu-emacs@gnu.org; Sat, 11 Jun 2022 04:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzwOc-0003yc-1O for bug-gnu-emacs@gnu.org; Sat, 11 Jun 2022 04:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jun 2022 08:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55900 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55900-submit@debbugs.gnu.org id=B55900.165493572715207 (code B ref 55900); Sat, 11 Jun 2022 08:23:01 +0000 Original-Received: (at 55900) by debbugs.gnu.org; 11 Jun 2022 08:22:07 +0000 Original-Received: from localhost ([127.0.0.1]:51819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzwNj-0003xD-IJ for submit@debbugs.gnu.org; Sat, 11 Jun 2022 04:22:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzwNh-0003wb-0c for 55900@debbugs.gnu.org; Sat, 11 Jun 2022 04:22:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzwNb-0004v6-Gs; Sat, 11 Jun 2022 04:21:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Lhay4LT0PIhJ3PV9C5bgu+ktr3wCU+O1VTcK7WVfQAA=; b=pLaLNHHzGSVQraT0X6ca Z9k0V5baNgv91SinfQlqoUlv6NFMpVjIHOhEZxRKrzHxqT6XAE87iMoSJvADSJBzTd/tJ+kdxh7oC OxQgRrTsn4ppa494HogIU8xIbl4Yg6KTKBJ9kXl7dBBIhohnqfP9sYZAbLX/w4lyzuFPBziDYsO9i oCVqenav/zxeDWIONQE9hGlS5ZINUUiz4FLbZUIc+Z2nRs0KvSpk+74fyHz71lP2FAK1qM4an0tdV HdcYdyc5nk0MGebtgGvxZ4KqzxXxkKpDsjvS0/AJEtmVOkPh2ITjRMrwLJkio684OFV7anQfUD4Zf 9CxdtCqx4z1SDg==; Original-Received: from [87.69.77.57] (port=1601 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzwNZ-0006b5-RO; Sat, 11 Jun 2022 04:21:59 -0400 In-Reply-To: (jaft.r@outlook.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234254 Archived-At: > From: "Wamm K. D." > Date: Sat, 11 Jun 2022 01:52:13 -0500 > > Pretty much as the subject describes; this should allow for users to > lazily load hierarchy branches when loading everything at once would > otherwise be too consuming, up-front (or if dealing with an infinite > tree). Thanks. > * lisp/emacs-lisp/hierarchy.el (hierarchy-add-tree) (hierarchy-add-trees): > Add parameter 'delay-children-p'. Please use our style of commit log messages. The above should be * lisp/emacs-lisp/hierarchy.el (hierarchy-add-tree) (hierarchy-add-trees): Add parameter 'delay-children-p'. > +(defun hierarchy--create-delayed-tree-widget (elem labelfn indent fn) > + "Return a list of tree-widgets for a hierarchy created from the childrenfn. The first line of the doc string should ideally mention the arguments. This one doesn't, and it also seems to misname one argument: it's FN, not childrenfn, right? Can this be improved? Can you add some tests of this new functionality? Also, I think this warrants a NEWS entry to describe the new feature.