From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56393: Actually fix the long lines display bug Date: Tue, 19 Jul 2022 17:19:55 +0300 Message-ID: <83wnc9mbg4.fsf@gnu.org> References: <38c1a31040d2d2bc47ae@heytings.org> <34362AA6-6404-4727-9C60-6B6CA6736DD4@gnus.org> <83v8rvpxx7.fsf@gnu.org> <209e6aa436f84e1f729a@heytings.org> <83sfmzpw4e.fsf@gnu.org> <83h73epq7v.fsf@gnu.org> <83cze2pmtk.fsf@gnu.org> <838roqpkjs.fsf@gnu.org> <831quipdt2.fsf@gnu.org> <83r12intar.fsf@gnu.org> <83lespomnu.fsf@gnu.org> <83fsixnwh3.fsf@gnu.org> <834jzdnsxw.fsf@gnu.org> <83y1wpmciw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, larsi@gnus.org, 56393@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 19 16:24:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDo97-0000yc-Rd for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jul 2022 16:24:22 +0200 Original-Received: from localhost ([::1]:49982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDo96-0001w5-Sy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Jul 2022 10:24:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDo5u-0006r2-TW for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 10:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDo5u-0007nt-KY for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDo5u-00006U-G9 for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2022 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2022 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56393 X-GNU-PR-Package: emacs Original-Received: via spool by 56393-submit@debbugs.gnu.org id=B56393.165824041432764 (code B ref 56393); Tue, 19 Jul 2022 14:21:02 +0000 Original-Received: (at 56393) by debbugs.gnu.org; 19 Jul 2022 14:20:14 +0000 Original-Received: from localhost ([127.0.0.1]:54841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDo58-0008WN-9s for submit@debbugs.gnu.org; Tue, 19 Jul 2022 10:20:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDo56-0008W5-De for 56393@debbugs.gnu.org; Tue, 19 Jul 2022 10:20:12 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDo51-0007d1-0u; Tue, 19 Jul 2022 10:20:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Iang/kjSAvmQp/nu2M9NUxmhQDTh2FDG8+LV+IKSJK8=; b=eovpeY2AiKsf bFIOQqu3sDvu7OrvyaXd0Y7dP4AF7UFbO94GnhZoQov6FA98HRZloHuv4msDTCEjq6qb8fBmSJ/mT O22qPTOKGGD9ZuPEKY8kMm78NIFnyJFGcyt6bRfMqcxOwMyU9cF5S6U47jNPOY5Pa7Sc7b41j0mKq Lk3f0iX25lxvncyusXvFX3/d4GKUcPeUiHbDcCb0vRxBR2OKiuKFO75dJ+37rfjjJPFVmlAaV8Vsl qn2zO/x9/NEk7Ax+Rg0D1LvF1+QjMyhqPqg55OIr/sHBZseK4xe5E5ddliIWIWAnMeMl77X+wsurp 79eicI5E8ne1dzNi6S6HPQ==; Original-Received: from [87.69.77.57] (port=2657 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDo50-00024S-Fl; Tue, 19 Jul 2022 10:20:06 -0400 In-Reply-To: (message from Gregory Heytings on Tue, 19 Jul 2022 14:06:17 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237443 Archived-At: > Date: Tue, 19 Jul 2022 14:06:17 +0000 > From: Gregory Heytings > cc: gerd.moellmann@gmail.com, larsi@gnus.org, 56393@debbugs.gnu.org > > > Why is that a problem? For this feature, we don't need the exact number > > of modifications in character units. > > Again, because I want to skip the long line detection code/overhead for > normal editing operation (typing one character at a time). That's not the problem you presented. You presented an opposite problem: where inserting many characters bumps the tick by just 1. I asked why that is a problem. > > Fine by me, but I think this is over-engineered. > > Fine, but then you'd have to tell me how to do that in another way (that > is, how to not trigger the long line detection code when the buffer has > only changed a little), or to convince me that the 13 ms overhead is okay. That's not what I'm saying. I'm saying that not recomputing the long lines when the user types "C-u 100000 a" is not a catastrophe. > > Also, please add a comment there explaining the heuristics, including > > the cases we know about where the counters could behave "strangely" or > > fail to catch changes. > > > > I'll do that. Thanks.