From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Fri, 11 Nov 2022 09:29:11 +0200 Message-ID: <83wn82osoo.fsf@gnu.org> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <87fseqtpiu.fsf@dfreeman.email> <875yfm8lzf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25892"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58790@debbugs.gnu.org, felician.nemeth@gmail.com, stefankangas@gmail.com, danny@dfreeman.email, dgutov@yandex.ru To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 08:30:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otOUV-0006dn-Hp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 08:30:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otOUH-0003Mh-Hn; Fri, 11 Nov 2022 02:30:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otOUF-0003MS-Mi for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 02:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otOUF-0002Hg-6d for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 02:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otOUE-0006nm-MX for bug-gnu-emacs@gnu.org; Fri, 11 Nov 2022 02:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Nov 2022 07:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166815177326090 (code B ref 58790); Fri, 11 Nov 2022 07:30:02 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 11 Nov 2022 07:29:33 +0000 Original-Received: from localhost ([127.0.0.1]:44982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otOTl-0006mk-CN for submit@debbugs.gnu.org; Fri, 11 Nov 2022 02:29:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otOTh-0006mW-6t for 58790@debbugs.gnu.org; Fri, 11 Nov 2022 02:29:32 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otOTa-0001PT-Lm; Fri, 11 Nov 2022 02:29:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=vn4F6gLq5tWCqWsA8B4YbfDwhB070wc4ECF1LG1vjmE=; b=r0z9DsH4vjCwmjMsmhwL x4ImtQ2GdPZ22OqPzWkIMsrupetCR5H0os7xszcIKae2jEk2rKsoKXRIoKcwm1xrPyKGtd3DimVVK aTYuJ0rGXrIlRQ0AbK1Cw3JQmT9Y7AnacOwJsCRCrZ3he0rduNb2o4rN2icMZmgS0Mud7zf3nPo5W 4lwbVNT2oylSFjt7i4YZm8Fw4/vKw6bvPufVhskP5EHfjp0PPyNxGdw7G5VI++Re1IR2vl6dqlKxK IDcHeMB6dU3CLqk9DXvdfoZNb/uZ/OUmhLx416SVs/mCxMIj2f++zXmckAFRL4/yDwFQGWJhq7s/1 VazGEZYiuJ6y0Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otOTO-0007dA-1w; Fri, 11 Nov 2022 02:29:21 -0500 In-Reply-To: <875yfm8lzf.fsf@gmail.com> (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Thu, 10 Nov 2022 22:48:20 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247573 Archived-At: > From: João Távora > Cc: Eli Zaretskii , 58790@debbugs.gnu.org, > felician.nemeth@gmail.com, stefankangas@gmail.com, dgutov@yandex.ru > Date: Thu, 10 Nov 2022 22:48:20 +0000 > > Danny Freeman writes: > > > In reviewing the comments over and over I've made a modification to > > the second patch involving the warning message. Instead of using an > > arbitrary symbol I realized that the function `find-file-name-handler' > > works when a nil value for the second argument (operation). > > I've now pushed the first patch, but I held off the second patch. > > I don't see this OPERATION=nil option documented in the docstring of > find-file-name-handler, so I'm not sure we should rely on it. > > I think we should provide OPERATION here, because what we want to check > is if we, Emacs, can actually visit the file designated by the URI. So > I think passing something like 'access-file' as the OPERATION argument > makes more sense. But Eli probably has more knowledge here. Maybe > passing nil is indeed correct. I think you are right, but Michael (CC'ed) will know for sure.