From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59459: 29.0.50; Compilation warnings without tree-sitter Date: Tue, 22 Nov 2022 14:21:08 +0200 Message-ID: <83wn7n18p7.fsf@gnu.org> References: <9FA0FE0E-30D9-47DB-8263-F75567B6F228@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9788"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59459@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 13:22:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxSIA-0002J1-93 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 13:22:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxSI0-0005jY-J9; Tue, 22 Nov 2022 07:22:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxSHq-0005jD-G6 for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 07:22:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxSHp-0000hb-RG for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 07:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxSHp-0002zO-NB for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 07:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 12:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59459 X-GNU-PR-Package: emacs Original-Received: via spool by 59459-submit@debbugs.gnu.org id=B59459.166911967511432 (code B ref 59459); Tue, 22 Nov 2022 12:22:01 +0000 Original-Received: (at 59459) by debbugs.gnu.org; 22 Nov 2022 12:21:15 +0000 Original-Received: from localhost ([127.0.0.1]:50108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxSH4-0002yK-Uc for submit@debbugs.gnu.org; Tue, 22 Nov 2022 07:21:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxSH3-0002y8-7b for 59459@debbugs.gnu.org; Tue, 22 Nov 2022 07:21:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxSGx-0000bs-Uy; Tue, 22 Nov 2022 07:21:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GLRVxus4BS82DXXry2nOuNZlTXUEm3mpDDQ/Z0oZnkE=; b=oQZh0ReytNaFoCLbg3dj Rf8N3MBu0zWs8VRC22CHFcnj6HQWGksXXqPtVF3tOJnx4N25S1xHXQOkXrBjTUq5R7QA4u0EVf982 9v0BhWoWxSEaR3tbsWEBiaGvLsLibIAQuGQKhGIYJoxT7PtrH8eqos071TLm3gXZHYEup1nnVltFx OO+S658PSchjFuXM8cyKk2rqpea5RAFA2XAckJcEyGlfjR0evOJ7+yuxuOQ/fA2/FHXBfXdRDChpP yh4/sSarL3t0yjiVEN66lAn+wD1u+DH3VuXtgjEAJHXUSLTNxMFMrZJaMIxKokZcqobFhwE25iGAK Qog49YQwCMdyag==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxSGk-0000FF-SA; Tue, 22 Nov 2022 07:21:07 -0500 In-Reply-To: <9FA0FE0E-30D9-47DB-8263-F75567B6F228@gmail.com> (message from Yuan Fu on Mon, 21 Nov 2022 14:01:14 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248625 Archived-At: > From: Yuan Fu > Date: Mon, 21 Nov 2022 14:01:14 -0800 > > [Continuing from bug#59426] > > Those warnings are due to no-tree-sitter build not having functions > defined in treesit.c. Eli fixed those warnings by adding > declare-function’s in every file using those functions. Can we make it a > bit nicer for lisp developers? Maybe defining those functions with > dummies with something like > > (defun xxx > (error ’treesit "Tree-sitter not available")) > > ? I'm not sure this is justified. The cases where a build lacks a very large group of primitives references in *.el files are quite rare in our practice; about the only two examples I know of are xwidgets.el and treesit.el (plus modes which use tree-sitter). It's easy enough (albeit annoying) to add a few declare-function's, so unless we are going to have more and more of these cases, adding a whole new infrastructure, let alone tricks like the above, which will raise a lot of brows, sound excessive to me.