From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Date: Fri, 25 Nov 2022 22:18:56 +0200 Message-ID: <83wn7iu6rz.fsf@gnu.org> References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36240"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58877@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 21:19:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyfAK-00094D-U3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 21:19:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyfAC-00019T-29; Fri, 25 Nov 2022 15:19:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyfA8-00018z-32 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 15:19:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyfA6-00053E-R0 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 15:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyfA6-0002Jv-H3 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 15:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.16694075238891 (code B ref 58877); Fri, 25 Nov 2022 20:19:02 +0000 Original-Received: (at 58877) by debbugs.gnu.org; 25 Nov 2022 20:18:43 +0000 Original-Received: from localhost ([127.0.0.1]:37270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyf9m-0002JK-Op for submit@debbugs.gnu.org; Fri, 25 Nov 2022 15:18:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyf9j-0002J6-5Q for 58877@debbugs.gnu.org; Fri, 25 Nov 2022 15:18:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyf9d-0004yK-Ul; Fri, 25 Nov 2022 15:18:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bDMh6Vt/0LtNNnBrP3jrXXChBfHcPrb+hYLJpntNDQU=; b=EetR370p/y5d xYV/Yf3joty+jIh9+6nE5FaNgiV8ITuQfoO14qhT+ebFM9Z5CL6z+dQYlmuaUC7tmSXDnLwH3kmnF l4P1zJReXWNfwfazQaoYo+ZuMWeKMcdU2P/x/ZbQoThWX0ok6K6ADhwhvvg9D++DTG/mXb5IYoT13 0rDyqJxk5STJpnx8NQE2IC3LIEvjaA8QLjpX5Xt4jeFcc47GNVQ+EMBLNuvtqEEKX2Xhd2LY5KNfi zNvD1tfl8+CPe/1V2PgdP1K1i3PWiN66/mDqSO0vVacp5ANep2jUhNvFZE/hAEj4gPsmgfN5sBsCV wIMgF7aCAj/65PFz8ZaJ5w==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyf9d-0005zF-ED; Fri, 25 Nov 2022 15:18:33 -0500 In-Reply-To: (message from Jim Porter on Fri, 25 Nov 2022 11:31:07 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249025 Archived-At: > Date: Fri, 25 Nov 2022 11:31:07 -0800 > Cc: 58877@debbugs.gnu.org > From: Jim Porter > > Hm, it looks like the emacsclient may not be starting up correctly. > Could you try the attached patch? I doubt this will fix the tests, but > hopefully you'll get some more-useful error messages. Here are the failure info from each failed test after this patch: Test server-tests/emacsclient/create-frame condition: Output: (ert-test-failed "timed out waiting for (or (= (length server-clients) (1+ starting-client-count)) (eq (process-status emacsclient) exit-status)) to be non-nil") FAILED 1/7 server-tests/emacsclient/create-frame (5.062500 sec) at lisp/server-tests.el:138 Test server-tests/emacsclient/eval condition: Output: (wrong-type-argument number-or-marker-p nil) FAILED 2/7 server-tests/emacsclient/eval (0.109375 sec) at lisp/server-tests.el:150 Test server-tests/emacsclient/server-edit condition: Output: (ert-test-failed "timed out waiting for (get-buffer \"file.txt\") to be non-nil") FAILED 3/7 server-tests/emacsclient/server-edit (5.156250 sec) at lisp/server-tests.el:129 Test server-tests/server-force-stop/keeps-frames condition: Output: (ert-test-failed ((should (eq (process-status emacsclient) 'run)) :form (eq exit run) :value nil)) FAILED 4/7 server-tests/server-force-stop/keeps-frames (0.109375 sec) at lisp/server-tests.el:159 Test server-tests/server-start/stop-prompt-with-client condition: Output: (ert-test-failed ((should (length= (frame-list) 2)) :form (length= (#) 2) :value nil)) FAILED 7/7 server-tests/server-start/stop-prompt-with-client (0.125000 sec) at lisp/server-tests.el:106