From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62333: 30.0.50; Issue with tree-sitter syntax tree during certain changes Date: Sat, 25 Mar 2023 17:41:49 +0300 Message-ID: <83wn34c2qa.fsf@gnu.org> References: <87fs9yur7r.fsf@gmail.com> <2fd8f2b8-d9c4-c825-a789-f2d42324859f@yandex.ru> <09539C5E-23DA-4B00-A3F6-873A41D6A2CE@gmail.com> <83h6uc549z.fsf@gnu.org> <665745A2-FDC8-45DE-BFF5-2F688FC85431@gmail.com> <491b788f-c3c3-4877-daa0-f515be9f3a17@yandex.ru> <83sfduelab.fsf@gnu.org> <8FC25A01-6934-43BB-899C-CA5926BEA3CF@gmail.com> <83jzz5c8ml.fsf@gnu.org> <83edpdc6sn.fsf@gnu.org> <1ca302bf-99dc-7f9e-8544-063064a1cb21@yandex.ru> <831qlcdisi.fsf@gnu.org> <398721ad-79b0-3f6d-97b3-4902d9bfbe39@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19829"; mail-complaints-to="usenet@ciao.gmane.io" Cc: wkirschbaum@gmail.com, casouri@gmail.com, 62333@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 15:43:40 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg57L-0004xv-SS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 15:43:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg56t-0000z1-LQ; Sat, 25 Mar 2023 10:43:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg56n-0000yV-Cb for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:43:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg56m-0008Gt-4W for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:43:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg56j-0000UK-Sy for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 10:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 14:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62333 X-GNU-PR-Package: emacs Original-Received: via spool by 62333-submit@debbugs.gnu.org id=B62333.16797553231805 (code B ref 62333); Sat, 25 Mar 2023 14:43:01 +0000 Original-Received: (at 62333) by debbugs.gnu.org; 25 Mar 2023 14:42:03 +0000 Original-Received: from localhost ([127.0.0.1]:43214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg55m-0000T3-RS for submit@debbugs.gnu.org; Sat, 25 Mar 2023 10:42:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg55k-0000SO-El for 62333@debbugs.gnu.org; Sat, 25 Mar 2023 10:42:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg55d-00083i-Q3; Sat, 25 Mar 2023 10:41:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=k+/RCpFAk6FLcxSLEWy4QQOGAAor0nMZ8mrTFADGZt0=; b=QT6JAQd3Vjoh POcZ9K+cb8q3ia76WIb+Bi0+kp9zuW9jbJGO8pALW9tTnPjsJSKX39o64kTHtTBZd20hFj4IeRrfD boWFB1HgsmW2CiV+57BHd9yLaTt8hrMkmSYHUDNiRTjkc5msnbElurXwKveWeeWiOZcSIOd0NyqYu X0/rH0JU3idR4dakn466cxFu37Jen3jLKL1pKQCHVJ9E1c9FQzbg633I+CdrmjJu/g0j5OE/AcXdW kRC1JMrKAp4bQGWzZUynVPLY/n8DZVDbCHXZupJE+rN5QnJJj9fm/ID3zEE4jAZDhvXb5WRwtJpPR iqmVvCs84n5QRzWxS8F12Q==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg55d-0000ka-8O; Sat, 25 Mar 2023 10:41:53 -0400 In-Reply-To: <398721ad-79b0-3f6d-97b3-4902d9bfbe39@yandex.ru> (message from Dmitry Gutov on Sat, 25 Mar 2023 16:18:12 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258585 Archived-At: > Date: Sat, 25 Mar 2023 16:18:12 +0200 > Cc: wkirschbaum@gmail.com, casouri@gmail.com, 62333@debbugs.gnu.org > From: Dmitry Gutov > > > mixed-major-mode shouldn't be a problem. > > Why wouldn't it? Because the sexp ends inside the current mode's block. > >> Long lines? > > > > Easy to test, and the call to widen will do nothing anyway in that > > case. > > Okay. Because of locked narrowing, I guess. Yes. > >> Because if we wanted to widen in all similar situations, we might as > >> well make it not obey the narrowing at all. > > > > It is impossible to not obey narrowing, not in Emacs. I told that and > > explained that many times already, including simple examples of what > > trouble this could cause to even the most innocent Lisp code. I hoped > > that by now this should no longer be brought forward. > > Okay. But do you advocate all uses of tree-sitter to (widen) first? No, just in sexp-movement functions, at least for now. If we discover this is need in many more situations, we might consider more drastic measures. But I don't think we are there yet. We've discovered just one such case, in just one such mode, and it's on master. We still have ample time to see how widespread this is.