From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Fri, 07 Apr 2023 14:17:49 +0300 Message-ID: <83wn2ondpe.fsf@gnu.org> References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile9t5uj.fsf@gmx.de> <87ttxssyef.fsf@gmx.de> <87o7o0rvax.fsf@gmx.de> <835ya8otvh.fsf@gnu.org> <83355cot57.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27748"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62694@debbugs.gnu.org, michael.albinus@gmx.de To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 07 13:18:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkk6i-00070g-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Apr 2023 13:18:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkk6W-00005s-O6; Fri, 07 Apr 2023 07:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkk6V-00005C-5a for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 07:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkk6U-00028w-NK for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 07:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkk6U-000150-6M for bug-gnu-emacs@gnu.org; Fri, 07 Apr 2023 07:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Apr 2023 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.16808662454102 (code B ref 62694); Fri, 07 Apr 2023 11:18:02 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 7 Apr 2023 11:17:25 +0000 Original-Received: from localhost ([127.0.0.1]:55824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkk5t-000145-6g for submit@debbugs.gnu.org; Fri, 07 Apr 2023 07:17:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkk5q-00013q-Pn for 62694@debbugs.gnu.org; Fri, 07 Apr 2023 07:17:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkk5l-0001qe-8v; Fri, 07 Apr 2023 07:17:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FaxIcUs+3wL8WUNgiWh4B1jQCKr6/4NbciYU3LhzLRk=; b=rWJutxsw4sHEeoGx7ebH E8Xv6/whG7HQ/dh7A1nMVZuXnbTW91UyB363hxrierFO2VAZ8e3kbIDV0j3AE6dzYV1/8xRdpICst cJ+UO+HFWJelMhWLoALw+Jk2B5KTZGI80HLWL+pVCEczWhWU0lCf34xVLqfyaDuU7Ui31uXBynosn NhAnmXbcu0O5ChdqjXqetiWPtEzub7FJP2pPUflrmjH6ck6f2BWaT3Z7CTcSqAyjGKIxf0IDy0UyH hsi936y0SVZ9PXz+DguBJIPf7KBlrQzhsGTitgnOawbyWz/hcywLObaJ9+2c3Nl1+Als63pLMlH4z iriY4J5Mlh0WAw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkk5k-0003tZ-Eq; Fri, 07 Apr 2023 07:17:16 -0400 In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Fri, 7 Apr 2023 12:06:46 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259392 Archived-At: > From: João Távora > Date: Fri, 7 Apr 2023 12:06:46 +0100 > Cc: michael.albinus@gmx.de, 62694@debbugs.gnu.org > > > The problem does exist, as Micheal has explained in so many words. > > Please trust him, as I do, that he knows what he is talking about, and > > would have solved this himself if an easier solution were possible. > > > > I see no significant complexity in adding a version test. We do that > > in umpteen other places with many other programs. > > It's not a version test. I've already done that for clangd, per Michael's > request. Here, pylsp's Debian packaging seems just to be buggy. > > Michael has previously found another buggy way to install clangd for > example, some method that created a 'clangd' script that didn't > even respond to `--version`. Those things are very hard to check against > and it's just not worth it. A version test doesn't have to mean literally testing the version. It can be a different test, specifically for the problematic behavior. If we understand the problematic behavior, we can test for it. (If we don't understand the problem, how do we know it is in the server and not in Eglot or elsewhere in Emacs?) > > > I don't understand what the problem with adding a 'pip install' line > > > to the EMBA scripts is. > > > > Again, please trust Michael on that one. We will not make any > > progress if we start second-guessing every request and decision of our > > peers, especially after you already suggested the upgrade, and Michael > > already explained why he thought it wasn't the best alternative. > > No he didn't. He _didn't_ explain what bad thing would come to the > world if pip install was added to the EMBA scripts. > > Alternatively, simply don't install any pylsp on EMBA. Boom, also > problem solved. Eventually, I will rework those tests to not rely on > pylsp at all, and I'll use something else to test those parts of eglot.el > > But spending time answering these mails doesn't make any progress in > that direction. Well, how about coding the test Michael asked, and I seconded, then? I agree that it will be a much better use of our time than keeping arguing about it. TIA