From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62762: circular dependencies in elisp files and make Date: Sat, 13 May 2023 13:58:25 +0300 Message-ID: <83wn1ca46m.fsf@gnu.org> References: <17b74a48-94e1-9106-cc79-d31972313910@gutov.dev> <1c5d0ff0-5bae-1123-d2f7-64d9013fbc0f@gmail.com> <6070e598-7dee-1b7a-7f97-26a90618cb7a@gmail.com> <64a61548-e343-992f-d193-d8ff4fe0623b@gmail.com> <831qjvjmw5.fsf@gnu.org> <48f15926-d002-877b-1d01-3a607fe42b76@gmail.com> <83v8h7hxlj.fsf@gnu.org> <38c89611-a929-1869-e70d-983bd7edad14@gmail.com> <83jzxnhv2o.fsf@gnu.org> <59ccf87f-effb-2168-2c17-34d950060b1b@gmail.com> <83354aixqy.fsf@gnu.org> <3ce7d18d-8190-a379-f503-5b0fef1dcb88@gmail.com> <831qjuisa4.fsf@gnu.org> <83y1lu505p.fsf@gnu.org> <9d8db5af-1917-1d0a-0360-ac122e137a53@gmail.com> <83ttwhbn7b.fsf@gnu.org> <9aa7edb6-c6c4-39ad-4302-371e5e58b4f6@gmail.com> <83sfc1bkt3.fsf@gnu.org> <83zg68afn9.fsf@gnu.org> <16f3f59c-ce2c-2b0d-fe56-8a85b79a1b3f@gmail.com> <83y1lsaaay.fsf@gnu.org> <63ccd7e3-f622-eef3-0ce4-4e7da4b92bb6@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28106"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 62762@debbugs.gnu.org, bzg@gnu.org, dmitry@gutov.dev, monnier@iro.umontreal.ca, acm@muc.de To: Max Nikulin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 13 12:59:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxmy6-00077u-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 May 2023 12:59:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxmxr-0003FT-NY; Sat, 13 May 2023 06:59:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxmxq-0003FL-I6 for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 06:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxmxq-0006nO-A1 for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 06:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxmxq-0005d3-2T for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 06:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 May 2023 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62762 X-GNU-PR-Package: emacs Original-Received: via spool by 62762-submit@debbugs.gnu.org id=B62762.168397551621605 (code B ref 62762); Sat, 13 May 2023 10:59:02 +0000 Original-Received: (at 62762) by debbugs.gnu.org; 13 May 2023 10:58:36 +0000 Original-Received: from localhost ([127.0.0.1]:36106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxmxP-0005cP-OH for submit@debbugs.gnu.org; Sat, 13 May 2023 06:58:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxmxN-0005cB-EM for 62762@debbugs.gnu.org; Sat, 13 May 2023 06:58:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxmxG-0006go-Mk; Sat, 13 May 2023 06:58:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=C41h+PoNz+GU5OPmO81rBvDbhVPpXbwo0afUWNZeeu8=; b=nu2u3nxonlmV mF2lNv27Zd+e5VgqEoXmvivZsKdwXxYJ5pf8Ho6JYfkS/qlHjqdNp7mSWFyBwi+1a7ChMSMS6zHRZ awKwT+D/fbpWk43gOcJ4UGyVZ+xXVncw5lRrnIOqFFgDK1dtzNIWOEmMApu2R4gADesgdqcswYH0j tFOU+LcpcCBaiZywK4yw1sP3WUdoFo2nLwj+ZN3YAJlNO36w8qVMfRMhYlQzfjo4FV5szoxDscTu1 4emFRpDArZ0tF0NT1LOv8vbc5DD7Ia9OftL4dllV1l/SBt8QQvSoV7PBd9ItRUimijsmtkqDR8E9r bUyJJfEqSzm4IaPHRFSfNQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxmxG-0006ev-5a; Sat, 13 May 2023 06:58:26 -0400 In-Reply-To: <63ccd7e3-f622-eef3-0ce4-4e7da4b92bb6@gmail.com> (message from Max Nikulin on Sat, 13 May 2023 17:25:06 +0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261677 Archived-At: > Date: Sat, 13 May 2023 17:25:06 +0700 > Cc: monnier@iro.umontreal.ca, yantar92@posteo.net, bzg@gnu.org, > dmitry@gutov.dev, 62762@debbugs.gnu.org, acm@muc.de > From: Max Nikulin > > On 13/05/2023 15:46, Eli Zaretskii wrote: > >> Date: Sat, 13 May 2023 14:34:06 +0700 From: Max Nikulin > >> > >> 1. A script reads dependency files (if they exist) created during > >> previous build and removes stale .elc files. > > > > This will break if the updated files have different dependencies. You > > need to recreate the dependencies each build. > > Let's consider a.el that contains (require 'd) or it autoloads some > macro from d.el. If a.el changed then a.elc is removed on this stage, so > updated a.elc will be created on the next stage. Dependency on d.elc is > known from previous build, so if d.el is changed then both a.elc and > d.elc are removed. If new (require 'd-new) is added to a.el then it is > not a problem as well. a.elc is removed due to changed a.el. d-new.elc > is either up to date or it is removed due to changes in its dependencies > or in d-new.el. I was talking about dependencies, not about stale files. They will need to be refreshed every build, because, unlike C sources, the *.el files change in that aspect much more frequently. > So no stale files should survive stage 1. The only issue with obsolete > dependencies is that compilation order may be not optimal. Stale files are already not an issue, because the build runs with load-prefer-newer set non-nil. > > Also, it is not clear what is the plan for the macros. If one of the > > macros used during byte compilation changes in incompatible ways, > > trying to byte-compile using Emacs which preloaded the previous > > (outdated) definition of the macro will fail. > > I hope, it is addressed above. It isn't. > > So some changes need > > also to generate a new Emacs binary, not just byte-compile in the > > right order. > > I expect that dependencies of the script removing stale files are > minimized. If changes in the breaks this script then it is time for > "make clean". If emacs binary depends on .elc files then some file may > be touched to let "make" know that the executable needs rebuild. I don't understand how this will work, but don't let me discourage you from trying to make it work and showing how. > > What is the plan for the various autoloads files? They depend on all > > the files, and many (all?) files depend on them. > > My plan is that autoloads/loaddefs are order-only dependencies for .elc > files. However autoloads/loaddefs files depends on all files necessary > to generate them. Same here. Thanks for working on this, anyway. If it can work, it could be an important change.