From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Tue, 04 Jul 2023 14:21:39 +0300 Message-ID: <83wmzfly64.fsf@gnu.org> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40526"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64311@debbugs.gnu.org, vas@oneofus.la To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 04 13:22:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGe6w-000AIq-A1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jul 2023 13:22:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGe6e-0007S5-Ao; Tue, 04 Jul 2023 07:22:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGe6c-0007Of-Kj for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 07:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGe6c-0001Ae-9v for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 07:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qGe6b-0006LD-Qa for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 07:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jul 2023 11:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.168846967224317 (code B ref 64311); Tue, 04 Jul 2023 11:22:01 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 4 Jul 2023 11:21:12 +0000 Original-Received: from localhost ([127.0.0.1]:35082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGe5n-0006K8-OU for submit@debbugs.gnu.org; Tue, 04 Jul 2023 07:21:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGe5i-0006JT-Qv for 64311@debbugs.gnu.org; Tue, 04 Jul 2023 07:21:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGe5d-0000zk-0u; Tue, 04 Jul 2023 07:21:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8993ox9P3fOYS92aS/hA9c/UnVG48Orltfr9rXgX+PA=; b=RlKqMxz3C+HM Dg7cCWm1WFYCppvjRrL/uhxQubHzEE2D1md74iryIsflBwACEcocLYS6MeeiN97eIzIxLq4dTFPlM 1Jr6JmxPLmgWUeEz1wJbNgNNXRQa7exfNXpmTq9YoyL1/yNTA5o/gcXTFcPpUlG3SIaQzxYFSFI1L 9srL/gBxRLrjwH7BdGwhUbnCyqRVv76s+L1i2TT2OGJynSaVW4KAzQqUqZANn0D2TY0SWxDsZjfGx RXe6WolFJB1RPzFkKFy7pujm723oABcqEfAb8lleDv3cjsHa3vAidyA5+0ZUtMFCQC8oc10vae+jU F0RIoWQKD4debFcvOPShCA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGe5c-0002Nw-H8; Tue, 04 Jul 2023 07:21:00 -0400 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264573 Archived-At: > Cc: 64311@debbugs.gnu.org > Date: Mon, 03 Jul 2023 23:32:49 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > diff --git a/lisp/shell.el b/lisp/shell.el > > index b74442f1961..39e12577280 100644 > > --- a/lisp/shell.el > > +++ b/lisp/shell.el > > @@ -346,10 +346,10 @@ shell-dirstack > > "List of directories saved by pushd in this buffer's shell. > > Thus, this does not include the shell's current directory.") > > > > -(defvaralias 'shell-dirtrack-mode 'shell-dirtrackp) > > - > > -(defvar shell-dirtrackp t > > - "Non-nil in a shell buffer means directory tracking is enabled.") > > +(define-obsolete-variable-alias 'shell-dirtrackp 'shell-dirtrack-mode > > + "???" > > + "Non-nil in a shell buffer means directory tracking is enabled. > > +Use the minor mode variable `shell-dirtrack-mode' instead.") > > Indeed `shell-dirtrackp` should not be defvar'd. > The above looks good to me. It doesn't look good to me, for the reasons I explained in the discussion. Do you see anything wrong with the alternative patch I proposed instead?