From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?UTF-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= Date: Fri, 07 Jul 2023 21:15:39 +0300 Message-ID: <83wmzbegfo.fsf@gnu.org> References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> <875y751tsz.fsf@web.de> <83wmzlsd4u.fsf@gnu.org> <83ttuhilpb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19638"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, zack@owlfolio.org, 64232-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 20:16:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHq0E-0004qj-7X for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 20:16:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHpzz-00082P-Ez; Fri, 07 Jul 2023 14:16:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHpzv-000826-0F for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 14:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHpzu-0002Ew-OV for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 14:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHpzu-00006B-Jr for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jul 2023 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64232 X-GNU-PR-Package: emacs Original-Received: via spool by 64232-done@debbugs.gnu.org id=D64232.168875374631424 (code D ref 64232); Fri, 07 Jul 2023 18:16:02 +0000 Original-Received: (at 64232-done) by debbugs.gnu.org; 7 Jul 2023 18:15:46 +0000 Original-Received: from localhost ([127.0.0.1]:43716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHpzd-0008A6-Ry for submit@debbugs.gnu.org; Fri, 07 Jul 2023 14:15:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHpza-0007qL-V0 for 64232-done@debbugs.gnu.org; Fri, 07 Jul 2023 14:15:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHpzV-0002Av-9G; Fri, 07 Jul 2023 14:15:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mWiXBZnmNtGIKgpRaoyGKPhmHnDEgGtSP6QpJdlfirA=; b=Xoh+SPAYyaZkun8SJ10w lEXfG6HU620NmTBF/8CGRroAiyrmfRwcIrdF0eRP2HOljd7wfpgAwXOrMK7IiSoPSSLQbEX+Etm12 a5LynV6WowoasxrHyEkCaMiZVWoYa5onM1T/LIVCbA+3PoN9La3z3otiPgfDFEpqdapxjLXk2J5Yr CDn0EAGJWRc+TRNmgmauD0NVVx7seRtDeOpzmt2irpGAgNzIENUjzntkYDlkyeGVuoL2xzWmLvq4d ds+Rx3+Y2+rllgxHxIO6Ywu3wtGro/DSponhKuTpXYfKTQY7p47nLMLmp2vLeVmQ2RjukUis3ESY8 XxL7WnGCTUgXmg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHpzU-0005g5-5P; Fri, 07 Jul 2023 14:15:37 -0400 In-Reply-To: (message from Stefan Monnier on Fri, 07 Jul 2023 12:10:41 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264741 Archived-At: > From: Stefan Monnier > Cc: michael_heerdegen@web.de, zack@owlfolio.org, 64232-done@debbugs.gnu.org > Date: Fri, 07 Jul 2023 12:10:41 -0400 > > >> > > --- a/lisp/emacs-lisp/bytecomp.el > >> > > +++ b/lisp/emacs-lisp/bytecomp.el > >> > > @@ -1128,7 +1128,8 @@ byte-compile-eval > >> > > ;; we arguably should add it to b-c-noruntime-functions, > >> > > ;; but it's not clear it's worth the trouble > >> > > ;; trying to recognize that case. > >> > > - (unless (get f 'function-history) > >> > > + (unless (or (get f 'function-history) > >> > > + (assq f byte-compile-function-environment)) > >> > > (push f byte-compile-noruntime-functions))))))))))))) > >> > > >> > Seems appropriate (and fixes this bug). > >> > Actually with that patch the situation looks already quite ok'ish to me. > >> Please install this on master, and thanks. > > Ping! Any reasons this was not yet installed on master? > > Oops, sorry. Pushed, Thanks.