From: Eli Zaretskii <eliz@gnu.org>
To: Valtteri Vuorikoski <vuori@notcom.org>
Cc: 64577@debbugs.gnu.org
Subject: bug#64577: 29.0.92; configure on NetBSD forces unstable terminfo library
Date: Wed, 12 Jul 2023 19:06:42 +0300 [thread overview]
Message-ID: <83wmz55d2l.fsf@gnu.org> (raw)
In-Reply-To: <wuuue7qt23f666mq7cwikck7yetavczjdoh3huevmtgmng7eea@zqjcvmn5la4e> (message from Valtteri Vuorikoski on Wed, 12 Jul 2023 17:06:08 +0300)
> Date: Wed, 12 Jul 2023 17:06:08 +0300
> From: Valtteri Vuorikoski <vuori@notcom.org>
> Cc: 64577@debbugs.gnu.org
>
> > diff --git a/configure.ac b/configure.ac
> > index 19575e8..21c396f 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -5212,7 +5212,7 @@ AC_DEFUN
> > ;;
> >
> > netbsd)
> > - if test "x$LIBS_TERMCAP" != "x-lterminfo"; then
> > + if test "x$LIBS_TERMCAP" != "x-lncurses"; then
> > TERMINFO=no
> > LIBS_TERMCAP="-ltermcap"
> > fi
>
> It fixes the immediate problem, yes. But I don't think this special
> case should stick around, since it seems relevant only to a very
> ancient version of NetBSD.
We don't want to drop support of old versions just because we can, and
we don't really know how "ancient" those ancient versions should
actually be to require this special case. We know that in May 2010 it
was TRT, but not when it stopped being TRT. Without knowing that, I'd
like to avoid removing this, at least until we hear a real problem
with it. Asking NetBSD users to install ncurses doesn't sound like a
problem to me.
> I tried out the following patch and it turns out that the thing that
> causes tparam1 aborts is actually TERMINFO=no:
That's strange, since termcap and terminfo are the same on NetBSD.
Maybe the problem is that TERMINFO=no means we don't compile
terminfo.c into Emacs, and/or also don't define TERMINFO, which could
bypass more code that's needed for terminfo? In that case, just
avoiding TERMINFO=no, even if ncurses were not found, could be another
good measure.
> If users with ancient NetBSD versions experience problems with
> libterminfo (that the original special case logic presumably avoided),
> they can install ncurses as a workaround.
That argument goes both ways, doesn't it?
next prev parent reply other threads:[~2023-07-12 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 20:37 bug#64577: 29.0.92; configure on NetBSD forces unstable terminfo library vuori
2023-07-12 12:11 ` Eli Zaretskii
2023-07-12 12:57 ` Valtteri Vuorikoski
2023-07-12 13:32 ` Eli Zaretskii
2023-07-12 14:06 ` Valtteri Vuorikoski
2023-07-12 16:06 ` Eli Zaretskii [this message]
2023-07-12 20:22 ` Valtteri Vuorikoski
2023-07-13 5:19 ` Eli Zaretskii
2023-07-13 9:35 ` Valtteri Vuorikoski
2023-07-15 8:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wmz55d2l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64577@debbugs.gnu.org \
--cc=vuori@notcom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).