From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64595: 30.0.50; 13-years old commented code in src/data.c:1608 (set_internal) Date: Thu, 13 Jul 2023 16:17:20 +0300 Message-ID: <83wmz43q8v.fsf@gnu.org> References: <87a5w0ngc8.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40262"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64595@debbugs.gnu.org To: Ihor Radchenko , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 15:18:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJwCz-000AEd-GS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 15:18:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJwCr-0002SJ-3p; Thu, 13 Jul 2023 09:18:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJwCo-0002S2-OF for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 09:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJwCo-0004sF-GA for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 09:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJwCn-0000AM-VY for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 09:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64595 X-GNU-PR-Package: emacs Original-Received: via spool by 64595-submit@debbugs.gnu.org id=B64595.1689254231544 (code B ref 64595); Thu, 13 Jul 2023 13:18:01 +0000 Original-Received: (at 64595) by debbugs.gnu.org; 13 Jul 2023 13:17:11 +0000 Original-Received: from localhost ([127.0.0.1]:53590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJwBz-00008g-1W for submit@debbugs.gnu.org; Thu, 13 Jul 2023 09:17:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJwBw-00008O-Kx for 64595@debbugs.gnu.org; Thu, 13 Jul 2023 09:17:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJwBr-0004aJ-8u; Thu, 13 Jul 2023 09:17:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=m8hlrZxglvDwGi931vLPsgss9/bQXkx2fAvFwd3U5GI=; b=qkFsficqPOv7 xGgfYq9JZhy0lJO/Br7vuZOKkJOvlZpHk7FfZOOT4t6JDDgIjJzlfZJpM/iOA6fSM6nn0tNQ7aJwV 9vdPjWUrAeHj0IVKE4pOWX5LgFSBfPg00FYdLQidrJQs038o4p4GGz5oXeM645IuC64LdSatuazcr y5naLNp4BaFTj3/BC1iDdQq508/KJcIJUJsWd4h8fZzWPRgqy/E2NU0glyRIf3YrlW7YLRm+/wkmn fgxQbDwsaTX1Ecbia/uKo/KLZaN6ncZu2ftRoHSLm7fKYdN08YDHrzxIphq6yxo3RQrM7EVxGOXvr W4rWzYsMyudlxfojSMS35g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJwBq-0003kw-OZ; Thu, 13 Jul 2023 09:17:03 -0400 In-Reply-To: <87a5w0ngc8.fsf@localhost> (message from Ihor Radchenko on Thu, 13 Jul 2023 12:31:03 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265019 Archived-At: > From: Ihor Radchenko > Date: Thu, 13 Jul 2023 12:31:03 +0000 > > While reading the sources, I found the following commented piece of > code in set_internal: > > /* If restoring in a dead buffer, do nothing. */ > /* if (BUFFERP (where) && NILP (XBUFFER (where)->name)) > return; */ > > This code has been changed 13 years ago and also commented immediately > (in the same commit): > > 94b612ad880e0d6eab6659347cb66e3a5310f8be > Author: Stefan Monnier > AuthorDate: Fri May 7 16:33:00 2010 -0400 > > Try and fix unbind_to when localness of binding has changed > * eval.c (unbind_to): Don't unbind a local binding into the global > binding when the local binding disappeared. Inversely, don't unbind > a global binding into a newly created local binding. > * data.c (set_internal): Make its `buf' arg into a `where' arg so we > can specify the frame to use, when applicable. Adjust callers. > > - if (buf == 0) > - buf = current_buffer; > - > /* If restoring in a dead buffer, do nothing. */ > - if (NILP (buf->name)) > - return; > + /* if (BUFFERP (where) && NILP (XBUFFER (where)->name)) > + return; */ > > I assume that after 13 years, it is safe to remove it. Stefan?