From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Thu, 20 Jul 2023 21:43:03 +0300 Message-ID: <83wmyu1l1k.fsf@gnu.org> References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <837cqu35lw.fsf@gnu.org> <87o7k6pmk3.fsf@localhost> <834jly351p.fsf@gnu.org> <87lefapkdx.fsf@localhost> <831qh230h5.fsf@gnu.org> <87wmyu8mi0.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6233"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 64735@debbugs.gnu.org, sbaugh@janestreet.com To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 20 20:43:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMYcW-0001Rl-5H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Jul 2023 20:43:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMYcC-0001e7-C1; Thu, 20 Jul 2023 14:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMYcA-0001du-SI for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 14:43:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMYcA-00020X-KU for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 14:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMYcA-0002Yz-GN for bug-gnu-emacs@gnu.org; Thu, 20 Jul 2023 14:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jul 2023 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.16898785599822 (code B ref 64735); Thu, 20 Jul 2023 18:43:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 20 Jul 2023 18:42:39 +0000 Original-Received: from localhost ([127.0.0.1]:59878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMYbm-0002YM-QG for submit@debbugs.gnu.org; Thu, 20 Jul 2023 14:42:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMYbk-0002Y6-9K for 64735@debbugs.gnu.org; Thu, 20 Jul 2023 14:42:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMYbe-0001xF-4f; Thu, 20 Jul 2023 14:42:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UAOLTQFKlvjSNejI7YfyNhtOOVwoCwqhzecvWxmLM9E=; b=pEBFyNdjek6+ BEev7CPSPrwq4Yrw6K51pmI6LHBdHMGh0FfSCDiCGB2Gc1UEgDAILNbxohA6AkCh6ohIzuM4PirJN ggBNEuguQ1zMeRWwFyG+kH0Q/sA6yvjbFwtJ2akMUg7DHKKYfuONS89VM0Q8qqQmNVem7YU7ptJzg OAyQPrQ1NPAR+EeRensTgMV5EDh837vvzlekn99ZtC56NcQqZ1YaNJCsrAIOQ4WcBwxXMZgtQzMXv BOvBBTivQqQwb90c6x043IArI7wNk81Dxg82pnhJXmJe0fCWuhM/3+z6aQeWXv3OSHsTtIjE9PHSY DqkGPYeZKBqj3G84jIBZXA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMYbd-0000pN-H6; Thu, 20 Jul 2023 14:42:29 -0400 In-Reply-To: <87wmyu8mi0.fsf@localhost> (message from Ihor Radchenko on Thu, 20 Jul 2023 18:29:43 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265630 Archived-At: > From: Ihor Radchenko > Cc: dmitry@gutov.dev, sbaugh@janestreet.com, 64735@debbugs.gnu.org > Date: Thu, 20 Jul 2023 18:29:43 +0000 > > Eli Zaretskii writes: > > >> No. It uses less excessive regexp matching Emacs is trying to do in > >> file-name-handler-alist. > > > > Where do you see regexp matching in the profiles you provided? > > I did the analysis earlier for `directory-files-recursively'. See > https://yhetil.org/emacs-devel/87cz0p2xlc.fsf@localhost/ > > Just to be sure, here is perf data for > (ignore (let ((gc-cons-threshold most-positive-fixnum)) (benchmark-progn (find-lisp-find-files "/home/yantar92/.data" "")))) > > 54.89% emacs emacs [.] re_match_2_internal > 10.19% emacs emacs [.] re_search_2 > 3.35% emacs emacs [.] unbind_to > 3.02% emacs emacs [.] compile_pattern > 3.02% emacs emacs [.] execute_charset > 3.00% emacs emacs [.] process_mark_stack > 1.59% emacs emacs [.] plist_get > 1.26% emacs emacs [.] RE_SETUP_SYNTAX_TABLE_FOR_OBJECT > 1.17% emacs emacs [.] update_syntax_table > 1.02% emacs emacs [.] Fexpand_file_name > > Disabling `file-name-handler-alist' cuts the time more than 2x. Disabling file-handlers is inconceivable in Emacs. And I suspect that find-file-name-handler is mostly called not from directory-files, but from expand-file-name -- another call that cannot possibly be bypassed in Emacs, since Emacs behaves as if CWD were different for each buffer. And expand-file-name also conses file names. And then we have encoding and decoding file names, something that with Find we do much less. Etc. etc.