From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Wed, 26 Jul 2023 14:10:53 +0300 Message-ID: <83wmynnd1e.fsf@gnu.org> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33594"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, philipk@posteo.net, 64799@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 26 13:11:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOcQU-0008Ts-96 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Jul 2023 13:11:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOcQ7-0008Kb-C3; Wed, 26 Jul 2023 07:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOcQ2-0008K9-TT for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 07:11:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qOcQ2-00063J-LS for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 07:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qOcQ2-0001oM-Fx for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2023 07:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jul 2023 11:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.16903698276904 (code B ref 64799); Wed, 26 Jul 2023 11:11:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 26 Jul 2023 11:10:27 +0000 Original-Received: from localhost ([127.0.0.1]:47624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOcPT-0001nI-3O for submit@debbugs.gnu.org; Wed, 26 Jul 2023 07:10:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qOcPR-0001n2-7r for 64799@debbugs.gnu.org; Wed, 26 Jul 2023 07:10:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOcPK-0005wZ-B9; Wed, 26 Jul 2023 07:10:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FsRsC5Y5G+XP6ZoYzG9QXaQnHnfub16NVU7u6C7b8QM=; b=lvTCLiAeNR7a 9eCGSnL6iqaI9wMBe81UsYUr26FTsvcLlOq8y9B50xBkRS5Ta0gPKjU56l0z+Fz5CMEkEGSqzj+II hyOobXqG+W57mf1LWk/43H+lIaxpdsN9huQR5d1HGu4qvqY4wWZlrGtY6J6eESwCfA7kUPc+bZswe fmE2G4bQZj4fyw464Y5arfBgorLdNXLh7bH0eZ9Amj7VPTa1+OI5P87rS5ApjENWdFCf06ynokYwu nUJAPda30kplImTUR4aM0DVgf5beHsspNuVoKE7bhZoVe5cLnEwwCuMYN5RXtC70BCkXjIJAM6yzk yV7BJ0zCIk6b3yzCK8sL1g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOcP7-0001GF-Qq; Wed, 26 Jul 2023 07:10:17 -0400 In-Reply-To: <87jzun5l9p.fsf@protesilaos.com> (message from Protesilaos Stavrou on Wed, 26 Jul 2023 07:50:26 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266109 Archived-At: > Cc: 64799@debbugs.gnu.org > From: Protesilaos Stavrou > Date: Wed, 26 Jul 2023 07:50:26 +0300 > > >>> But a user option to change how the prompt text is constructed -- why > >>> not. E.g. one defaulting to "[%s] %s". > >> > >> Is there really such a wide range of options that users might be > >> interested in here? > > > > Protesilaos wanted to use a different format? > > For my use, and Emacs 28+, I want this: > > (format "%s %s" > (propertize (key-description key) 'face 'project-prompt-key) > label) > > The reason I mentioned the possibility of a user option is because > without the square brackets the bold face will not have the same effect > as the current design. The square brackets help add structure and make > it easier to identify the keys. The use of 'bold' without the square > brackets may make it more difficult for users to spot the keys. Beware: the 'bold' face changes the metrics of the font glyphs (wrt the 'medium' variant), and at least with some fonts could cause a small 1- or 2-pixel vertical resize of the mini-window, which is generally distracting and even annoying.