From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Fri, 28 Jul 2023 09:55:13 +0300 Message-ID: <83wmykjzji.fsf@gnu.org> References: <874jruy7xx.fsf@ledu-giraud.fr> <87ttztk0yw.fsf@tcd.ie> <87v8k9s6j9.fsf@ledu-giraud.fr> <83ilg8jzti.fsf@gnu.org> <87k00oo03r.fsf@ledu-giraud.fr> <838rh4jlsq.fsf@gnu.org> <87bklzol8n.fsf@ledu-giraud.fr> <877cwmo8ij.fsf@ledu-giraud.fr> <87y1oz54bn.fsf@ledu-giraud.fr> <87wn4dra0h.fsf@ledu-giraud.fr> <87bklhtwhd.fsf@ledu-giraud.fr> <871qgumqh7.fsf@ledu-giraud.fr> <83ila5n8co.fsf@gnu.org> <87fs59qx54.fsf@ledu-giraud.fr> <83wmyll9s5.fsf@gnu.org> <87bkfxcaa2.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32534"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, stefankangas@gmail.com, 61394@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 28 09:10:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPHcD-0008FV-Vg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jul 2023 09:10:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPHNS-0000FJ-DT; Fri, 28 Jul 2023 02:55:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPHNP-0000Ew-8r for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 02:55:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPHNP-0002HH-1R for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 02:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPHNO-0007BX-IV for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 02:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2023 06:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.169052727827581 (code B ref 61394); Fri, 28 Jul 2023 06:55:02 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 28 Jul 2023 06:54:38 +0000 Original-Received: from localhost ([127.0.0.1]:43523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPHMw-0007Ak-SS for submit@debbugs.gnu.org; Fri, 28 Jul 2023 02:54:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPHMq-0007AS-Ra for 61394@debbugs.gnu.org; Fri, 28 Jul 2023 02:54:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPHMk-0002EH-Ec; Fri, 28 Jul 2023 02:54:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=H7TvAyK21shVztoGLojJ3R/wHCBSwSMaIHvSGNBBqgM=; b=i/knye0nzGjc uBo88UnkgDl87in+Dqw+fqpJUUFYFElU6z8RRD1pTxpSSlkY0nTVrDXs1FIleYAbBi595Oe0HuG38 Go2Pg8/Dwmf6EZQuPYf5th6k+0eB5z8fghx0/M9NcqU42V5nJllkjq6O9Op1xVwQrgLVIKpC6SL2c 2xY0VZNXStEya0I55p4l1Ni3BXW3+EHj7zNL7FFUt8m4SL/t2o+meNT4oFc17nhoCo2cI2Od1tBSL KhXpvBYDnHRTWJXO9W7B1Wfe2nuNw2FWGg+jJzYt5HrY4kkZRu8znRRY7sqhvGPKN85dmBNQXl8Re Rw1y7ivZlwFC7ZtmIYnrAQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPHMj-0006Si-So; Fri, 28 Jul 2023 02:54:22 -0400 In-Reply-To: <87bkfxcaa2.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 27 Jul 2023 23:30:29 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266232 Archived-At: > From: Manuel Giraud > Cc: stefankangas@gmail.com, contovob@tcd.ie, 61394@debbugs.gnu.org > Date: Thu, 27 Jul 2023 23:30:29 +0200 > > Eli Zaretskii writes: > > [...] > > > Thanks, installed. But now 1 set in image-dired-util-tests fails; it > > sounds like the method of producing per-directory thumbnails has > > changed, and now produces a SHA-1 hash? Can you please look into > > fixing that test? > > Ok, I think this patch should do. Thanks, the tests now pass, but I wonder about this part: > (should (equal (cdr (file-name-split > - (image-dired-thumb-name "/tmp/foo.jpg"))) > - '("tmp" ".image-dired" "foo.jpg.thumb.jpg"))) > + (image-dired-thumb-name abs-path))) > + (list "tmp" ".image-dired" hash-name))) Does this mean that thumbnail naming under 'per-directory' has changed, and it now uses the SHA-1 hash of the base-name? IOW, does this mean your changes for bug#61394 included incompatible changes in behavior?