From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Wed, 02 Aug 2023 14:42:20 +0300 Message-ID: <83wmydzn4z.fsf@gnu.org> References: <874jruy7xx.fsf@ledu-giraud.fr> <877cwmo8ij.fsf@ledu-giraud.fr> <87y1oz54bn.fsf@ledu-giraud.fr> <87wn4dra0h.fsf@ledu-giraud.fr> <87bklhtwhd.fsf@ledu-giraud.fr> <871qgumqh7.fsf@ledu-giraud.fr> <83ila5n8co.fsf@gnu.org> <87fs59qx54.fsf@ledu-giraud.fr> <83wmyll9s5.fsf@gnu.org> <87bkfxcaa2.fsf@ledu-giraud.fr> <83wmykjzji.fsf@gnu.org> <877cqkcrds.fsf@ledu-giraud.fr> <83bkfwjkh8.fsf@gnu.org> <871qgsc9fv.fsf@ledu-giraud.fr> <83y1izj2q6.fsf@gnu.org> <87leezhwq0.fsf@ledu-giraud.fr> <87edko9ixu.fsf@ledu-giraud.fr> <87h6piu1zj.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16443"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, stefankangas@gmail.com, 61394@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 02 13:43:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRAG7-00044m-2P for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Aug 2023 13:43:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRAFw-00067R-Qc; Wed, 02 Aug 2023 07:43:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRAFq-000678-Ra for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 07:43:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRAFq-00055P-Bg for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 07:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRAFq-0002af-7q for bug-gnu-emacs@gnu.org; Wed, 02 Aug 2023 07:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Aug 2023 11:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.16909765439908 (code B ref 61394); Wed, 02 Aug 2023 11:43:02 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 2 Aug 2023 11:42:23 +0000 Original-Received: from localhost ([127.0.0.1]:48982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRAFD-0002Zk-9a for submit@debbugs.gnu.org; Wed, 02 Aug 2023 07:42:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRAFA-0002ZU-1S for 61394@debbugs.gnu.org; Wed, 02 Aug 2023 07:42:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRAF3-0004vQ-Is; Wed, 02 Aug 2023 07:42:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xwq08HAyMLFBNw1Fzx1E2IKI/xpfnAQL1La963WrDvs=; b=TUoUmvZeojXxyZemO140 0h76L8O61PLJhmtPiTvFt4uWpPsQzYdcupTM2v1ts5PBttkfe1/wUruz60dw/ilLil6iBmQF5ioUv GWulSF+j97z+m1GrRwNzAzkWY7ZoLNyPWiAuzoaf0zTgLHn1dQQTv7jqW009zwQu+cBz4o8Q4hhNz NCCO/tO+bBjq+kBftj/pD2/eGXAi0nCN60SKUTK/qvOWMTbwDb9xaXKIbJzICFwbSQmLrhp+xdvsG pG3DwCa31BOnxlaqV1sRDJFEZbKSVzwQqpn4GpDXgwPqjbKSHAWJTMzHkj3jLmIcxrHqJNKthcCgZ dOM7r17CsvaxxQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRAF3-00044I-2P; Wed, 02 Aug 2023 07:42:13 -0400 In-Reply-To: <87h6piu1zj.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 01 Aug 2023 19:05:52 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266491 Archived-At: > From: Manuel Giraud > Cc: stefankangas@gmail.com, contovob@tcd.ie, 61394@debbugs.gnu.org > Date: Tue, 01 Aug 2023 19:05:52 +0200 > > Manuel Giraud writes: > > > Hi, > > > > FTR, there is a thing that does not work with this "thumb name based on > > content": upon rotation the thumb is not updated properly. > > > > This comes from the fact that the image content has changed (obviously) > > so the new thumb will have a new name and is not displayed in the > > *image-dired* buffer 😅. I'd have to find a way around it. > > Hi, > > So here is a patch that fixes this issue. Thanks. Thanks. Maybe I'm missing something, but isn't the problem limited to just one method of naming the thumbnail files? If so, shouldn't these changes be limited to that method alone?