From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64908: 29.1; svg parse failure Date: Sat, 05 Aug 2023 13:07:38 +0300 Message-ID: <83wmy9ssyd.fsf@gnu.org> References: <83o7jnwfd3.fsf@gnu.org> <835y5vw1ay.fsf@gnu.org> <83350yvd5f.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4189"; mail-complaints-to="usenet@ciao.gmane.io" Cc: da_vid@orange.fr, 64908@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 05 12:08:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qSECi-0000uz-KL for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Aug 2023 12:08:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSECa-0007qd-Be; Sat, 05 Aug 2023 06:08:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSECY-0007ng-Vl for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 06:08:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qSECY-00046R-NJ for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 06:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qSECY-0001Bi-11 for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2023 06:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Aug 2023 10:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64908 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: unreproducible Original-Received: via spool by 64908-submit@debbugs.gnu.org id=B64908.16912300514525 (code B ref 64908); Sat, 05 Aug 2023 10:08:01 +0000 Original-Received: (at 64908) by debbugs.gnu.org; 5 Aug 2023 10:07:31 +0000 Original-Received: from localhost ([127.0.0.1]:55720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSEC3-0001Av-BW for submit@debbugs.gnu.org; Sat, 05 Aug 2023 06:07:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qSEC2-0001Aj-1U for 64908@debbugs.gnu.org; Sat, 05 Aug 2023 06:07:30 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSEBw-00043z-3v; Sat, 05 Aug 2023 06:07:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=WNDVAEDWAeHtyR2ZVGhsTp/5+IxfNF3JI0HVSofUsIs=; b=TubSK3Zj8UBM JAzn53Mp2BKUwGvHtmA9VRB0D/U+c81flnQ905qCZBYr1LkdGApSvdiMReQp8XKHgzUVc8kUXbZ7L SzL96rGL7f6noFutSqVljffbrvbUO0U+Doy9SioZXwDxptnBodWhkk5P+QmSggWI6vJecyUbxDV7n ylp5ynN1mUzdS1JHkDjS4v22r7nOMB7r5mYOSypW//WRX3108uObjpxM3IXxqCKgGIbvVBZC+94l/ 33qCktqUML5Hl+UaJzunN/eo/Ucy9y2syKcIkqC14ka8ABotgLWaKSuxpjxZ66JhKDp3ZXDMzbBDB Du4koxyfV4bBOKHcb6xboQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSEBv-00018b-Ju; Sat, 05 Aug 2023 06:07:23 -0400 In-Reply-To: (message from Alan Third on Sat, 5 Aug 2023 10:58:26 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266759 Archived-At: > Date: Sat, 5 Aug 2023 10:58:26 +0100 > From: Alan Third > Cc: Eli Zaretskii , 64908@debbugs.gnu.org > > diff --git a/src/image.c b/src/image.c > index c9420b48f4a..96e0f2a7225 100644 > --- a/src/image.c > +++ b/src/image.c > @@ -11161,6 +11161,21 @@ svg_css_length_to_pixels (RsvgLength length, double dpi, int font_size) > case RSVG_UNIT_IN: > value *= dpi; > break; > + case RSVG_UNIT_PERCENT: > + /* Percent is a ratio of the containing "viewport". We don't > + have a viewport, as such, as we try to draw the image to it's > + own desired size rather than dictate the size as if we were > + drawing icons on a toolbar or similar. This means that > + percent values are useless to us and we are best off just > + drawing the image according to whatever other sizes we can > + derive. > + > + If we do set explicit width and height values in the image > + spec, this will work out correctly as librsvg will still > + honour the percentage sizes in its final rendering no matter > + what size we make the image. */ > + value = 0; > + break; I don't see RSVG_UNIT_PERCENT anywhere in the librsvg headers on my system, so perhaps this was introduced by some later version, and should be guarded by LIBRSVG_CHECK_VERSION?