From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65609: 30.0.50; inhibit-eol-conversion breaks revert-buffer Date: Wed, 30 Aug 2023 17:22:46 +0300 Message-ID: <83wmxcfw3t.fsf@gnu.org> References: <837cpchd9w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19476"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, herbert@gojira.at, 65609@debbugs.gnu.org, andj.scott@gmail.com To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 30 16:24:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbM73-0004pT-LN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Aug 2023 16:24:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbM6u-0006LF-74; Wed, 30 Aug 2023 10:23:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbM6t-0006Ks-0U for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 10:23:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbM6s-0001r1-Oe for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 10:23:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbM70-0003uY-6f for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2023 10:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2023 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65609 X-GNU-PR-Package: emacs Original-Received: via spool by 65609-submit@debbugs.gnu.org id=B65609.169340540114987 (code B ref 65609); Wed, 30 Aug 2023 14:24:02 +0000 Original-Received: (at 65609) by debbugs.gnu.org; 30 Aug 2023 14:23:21 +0000 Original-Received: from localhost ([127.0.0.1]:53737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbM6L-0003tf-FA for submit@debbugs.gnu.org; Wed, 30 Aug 2023 10:23:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbM6J-0003tT-HP for 65609@debbugs.gnu.org; Wed, 30 Aug 2023 10:23:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbM66-0001iN-6o; Wed, 30 Aug 2023 10:23:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=4yX4Dxcy6j06ybs5Og2RnrVHUVzOYyRxgYclet5izgM=; b=K5zl+MDzvSblcot58HA2 PkKYX0OBLlzwWqHGsQ8JcUnHe6HbOa2AXtKlFiMAv0zrOphKzVsi9s+Rn3j4hD1k/LVsNrUhM3YtQ i1EYtDR3jEsVypAuMSKTU7QY0iJBFouDBErwUQoRL97hrEuLcWAfV77UkejfmoS835MlSkl33blLF Dyz6MHvhvE48W8L1HtbM3hV+J4J9Yj/B7RyUc01QP65cRZgHajV9eb6zWUyiqaNvDrsHnJCFJ4FR3 GahKLPXwq4brwD5VwBt74I0jGYB1PE0EWr3it4o6+tAg20v2rBFXSX5FfzhiYrlG/6ki4qW53Sr7z aiW563z6N4SyqQ==; In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Wed, 30 Aug 2023 15:42:48 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268715 Archived-At: > Date: Wed, 30 Aug 2023 15:42:48 +0200 > Cc: 65609@debbugs.gnu.org > From: Gerd Möllmann > > On 30.08.23 15:26, Eli Zaretskii wrote: > > Po Lu, I think we need the patch below to fix this. Gerd, does this > > solve your problem as well, including the abort during bootstrap? > > Herbert, I think this could also be related to the problems you see, > > so please try the patch below. > > > > diff --git a/src/fileio.c b/src/fileio.c > > index 23e1a83..8919e08 100644 > > --- a/src/fileio.c > > +++ b/src/fileio.c > > @@ -4805,7 +4805,7 @@ DEFUN ("insert-file-contents", Finsert_file_contents, Sinsert_file_contents, > > > > /* 'try' is reserved in some compilers (Microsoft C). */ > > ptrdiff_t trytry = min (gap_size, READ_BUF_SIZE); > > - if (!NILP (end)) > > + if (seekable || !NILP (end)) > > trytry = min (trytry, total - inserted); > > > > if (!seekable && NILP (end)) > > With this patch, the abort during bootstrap no longer happens. Thanks for testing. > Thanks! That was quick ;-). It was an easy test case and a stunning failure.