From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66636: Move lexical-binding warning from checkdoc to byte-compiler Date: Fri, 20 Oct 2023 10:01:44 +0300 Message-ID: <83wmvhsron.fsf@gnu.org> References: <48764CD1-C80F-4613-9848-BD8CA9203A40@gmail.com> <87ttql4yfq.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattias.engdegard@gmail.com, 66636@debbugs.gnu.org To: Po Lu , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 20 09:03:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtjXR-00012h-F5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Oct 2023 09:03:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtjWv-0008RK-8B; Fri, 20 Oct 2023 03:02:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtjWl-00087N-LD for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 03:02:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtjWl-0006Th-BT for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 03:02:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtjXC-0003rj-BL for bug-gnu-emacs@gnu.org; Fri, 20 Oct 2023 03:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Oct 2023 07:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66636 X-GNU-PR-Package: emacs Original-Received: via spool by 66636-submit@debbugs.gnu.org id=B66636.169778534514807 (code B ref 66636); Fri, 20 Oct 2023 07:03:02 +0000 Original-Received: (at 66636) by debbugs.gnu.org; 20 Oct 2023 07:02:25 +0000 Original-Received: from localhost ([127.0.0.1]:38523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjWb-0003ql-7w for submit@debbugs.gnu.org; Fri, 20 Oct 2023 03:02:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtjWY-0003qW-UO for 66636@debbugs.gnu.org; Fri, 20 Oct 2023 03:02:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtjW2-0006JT-8t; Fri, 20 Oct 2023 03:01:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HB3mMDNLCsD/H2xUbKl49CwB284y+Mtw0AGg2baBqko=; b=UBn22ydr+jx2wH4sjd5A 98y4nl46cibFe1z4i+Ezn069CbGhUQjVdd2+Vpm/p0nKw2yPXp9yNra/A8htIrUeD6m+PQvoGmHLq Zx2mFSStiKuvVqvdxYKk6idxwFcnMZFYllnrv/CpdK51QN+uHtXjGSXM7VKEQzY8WmKjombwNBtgQ xcwon5No0x3Tbx0rAmKYWdObHeo7IgrMW7LF+Hr2wjBhssv0Dr5BHTTsXMTTgPmZVAa6F5hM2TMtk i5t6r4P0xaiKfvFOqeVfB941O/WSAp658A7b9yVWBU4+Yb6GTTM04eTIFp3V8dRA00TU3FiGuCsNl h3y7SYvNaGAOdQ==; In-Reply-To: <87ttql4yfq.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272777 Archived-At: > Cc: 66636@debbugs.gnu.org > Date: Fri, 20 Oct 2023 14:09:45 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Mattias Engdegård writes: > > > The warning about a missing lexical-binding cookie rather belongs in > > the compiler than checkdoc, because it's not about documentation or > > style but code generation and ability to detect errors, both which are > > hindered by a missing cookie. > > > > Moving the warning to the compiler also makes it more widely seen. > > So long as this warning is only displayed within code part of Emacs > itself, there are no valid objections to such a change. > > But you have instead elected to generate warnings whenever such files > are byte-compiled. There exist many packages which do not enable > lexical binding, whose authors have studiously elected not to: most of > Drew Adams' for example. So this is tantamount to punitive action > against their users, in the form of an unsightly warning each time such > packages are installed. Cannot such packages disable this warning in file-local variables?