From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66769: 30.0.50; pixel-scroll-precision-mode and scroll-margin regression Date: Sat, 28 Oct 2023 09:43:19 +0300 Message-ID: <83wmv7ckmw.fsf@gnu.org> References: <877cn7xzg0.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23619"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66769@debbugs.gnu.org, aaronjensen@gmail.com To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 28 08:44:01 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qwd3B-0005yD-0w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Oct 2023 08:44:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwd2h-0006HQ-SI; Sat, 28 Oct 2023 02:43:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwd2h-0006HI-BO for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 02:43:31 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwd2h-0005oU-2c for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 02:43:31 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwd3C-0005mf-Fx for bug-gnu-emacs@gnu.org; Sat, 28 Oct 2023 02:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Oct 2023 06:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66769 X-GNU-PR-Package: emacs Original-Received: via spool by 66769-submit@debbugs.gnu.org id=B66769.169847542622194 (code B ref 66769); Sat, 28 Oct 2023 06:44:02 +0000 Original-Received: (at 66769) by debbugs.gnu.org; 28 Oct 2023 06:43:46 +0000 Original-Received: from localhost ([127.0.0.1]:37655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwd2w-0005lt-6k for submit@debbugs.gnu.org; Sat, 28 Oct 2023 02:43:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwd2t-0005le-HE for 66769@debbugs.gnu.org; Sat, 28 Oct 2023 02:43:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwd2I-0005m5-9h; Sat, 28 Oct 2023 02:43:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jQX+pN8LoFB7e3PrYqUAMm7qQVKu1HoY2vqsMcjaPNQ=; b=qVOjGqXzkobf jRVB3MT22tdr7kpYYrirqNI5NuMFtrKUT5/rdzGqakuRYADdaXWZjpRiZNO7EhASM+F+f3PigMAqu tSBefLtb1CJyD0RwdlGBOXeYUmY3oanJNz6PjDIMknt/2gwMUy6MzFOd0ti6yJC9aU8i2uHaYSlvr pkTHGUsxpZHSPfEyEDge95OMbkpbQtcLL1b+c+UWo/q3l1kdApit3YdbqTm2OKYCbGyOCAAPzamyt 2wcwo6Di9YgxTXF+2E1ERa5FHwY8wfJ4u4aHQDnHnNZFkDKFaJPU374Bijq0Wj6LOtnLYQNiISuEM vFy/tDjxDM5528xL9My+VQ==; In-Reply-To: <877cn7xzg0.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273413 Archived-At: > Cc: 66769@debbugs.gnu.org > Date: Sat, 28 Oct 2023 10:17:51 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Aaron Jensen writes: > > > Commit 1da4fca0647ebf1d5d6f12817301a17661560810 caused a regression of > > bug#52231 > > > > The repro is the same: > > > > (progn (setq scroll-margin 4) > > (pixel-scroll-precision-mode)) > > > > And scroll down a buffer with mouse wheel. > > > > The buffer does not scroll properly, it jumps back unless you scroll > > fast enough. > > Hmm, I'm not certain what the solution to this should be. > > For images to scroll properly, the "target point" must be derived from > whether the point is visible after scrolling, instead of outside a set > number of rows from the window start or end. Yet the latter information > is mandatory if the scroll margin is to be taken into account, and no > function supplies both besides posn-at-point, which is much too slow. What is the "target point" in the above text? target for what? > The immediate remedy is to restore the old code when scroll-margin is in > effect and document the consequent incapacity to scroll over large > images as an unfortunate corollary. Is that acceptable by you? Why not use the too-slow posn-at-point, but only in this case?