From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68006: 30.0.50; Image-mode speed Date: Sun, 24 Dec 2023 19:01:53 +0200 Message-ID: <83wmt3bkla.fsf@gnu.org> References: <87le9jlfd6.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30580"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68006@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 24 18:03:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHRsc-0007hS-NV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Dec 2023 18:03:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHRsR-0003oF-L5; Sun, 24 Dec 2023 12:02:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHRsP-0003nW-5x for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2023 12:02:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rHRsO-0001z5-UB for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2023 12:02:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rHRsU-0004Rd-SA for bug-gnu-emacs@gnu.org; Sun, 24 Dec 2023 12:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Dec 2023 17:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68006 X-GNU-PR-Package: emacs Original-Received: via spool by 68006-submit@debbugs.gnu.org id=B68006.170343733717009 (code B ref 68006); Sun, 24 Dec 2023 17:03:02 +0000 Original-Received: (at 68006) by debbugs.gnu.org; 24 Dec 2023 17:02:17 +0000 Original-Received: from localhost ([127.0.0.1]:53466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHRrk-0004QG-In for submit@debbugs.gnu.org; Sun, 24 Dec 2023 12:02:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHRrh-0004Pw-Mv for 68006@debbugs.gnu.org; Sun, 24 Dec 2023 12:02:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHRrV-0001m4-Vw; Sun, 24 Dec 2023 12:02:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=f00x4ZJFqfrPj7uX+7wHJIKQAaBgeuW0uf4FUW+M+lw=; b=ha6+EktV1XWS C+UgqhWtTKl/wCaajzviU00B12nsiU8EZI2H8wAA9W66s50mK1Q9XtBvA25BNvl7TrNIycVa1PDrr vN+SxmyX9J3ozjalUOh871BgGSBG9Y1/8P3vQaT1JEkHsxGIQX/AemUZwwhMn/IgfShwvfUSmxe5Q LLfRZhR7KBgao9geSmMjj8qaUJdjxPg1rH8ToAs+YJGtnSMkGeeeYFgM0mDAXzGCoXj/og6LVap2G y/VEGZ0+wc7xwnmpnIcaXC2J6Dx5pk3NYnPAudrSmsfTrsJ02CQsLHTxDsYNAsGkOWa7qryAKkTNV FYzsZLxROrjmbNQ8ymkTZg==; In-Reply-To: <87le9jlfd6.fsf@ledu-giraud.fr> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276819 Archived-At: > Date: Sun, 24 Dec 2023 17:44:37 +0100 > From: Manuel Giraud via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I was looking into performance issue using image-mode when going from > one image to the next/previous (with 'image-next/previous-file') and I > found those lines in "image-mode.el": > > --8<---------------cut here---------------start------------->8--- > ;; Discard any stale image data before looking it up again. > (image-flush image) > (setq image (append image (image-transform-properties image))) > (setq props > `(display ,image > ;; intangible ,image > rear-nonsticky (display) ;; intangible > read-only t front-sticky (read-only))) > --8<---------------cut here---------------end--------------->8--- > > The call to 'image-flush' defeats the entire purpose of having an image > cache. If I remove it, moving from previous/next is much more faster > (once this image is in the cache, of course). Do you know why this code > is like that? Look at its Git history, and look up discussions and bugs from those times. AFAIR, one problem is that images can change behind our backs. But maybe there are other reasons.