From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#4543: window-full-height-p Date: Sat, 26 Sep 2009 14:28:39 +0300 Message-ID: <83vdj6rllk.fsf@gnu.org> References: <4ABB19F5.50908@gmx.at> <4ABC73DB.1060308@gmx.at> <83vdj7tlup.fsf@gnu.org> <4ABCBEC7.70901@gmx.at> <4ABDE2C5.2070808@gmx.at> Reply-To: Eli Zaretskii , 4543@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1253965646 18885 80.91.229.12 (26 Sep 2009 11:47:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Sep 2009 11:47:26 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA To: martin rudalics , 4543@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 26 13:47:18 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MrVkD-00056f-W5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Sep 2009 13:47:18 +0200 Original-Received: from localhost ([127.0.0.1]:45378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrVkD-0000eF-Cb for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Sep 2009 07:47:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MrVk8-0000ds-Jl for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 07:47:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MrVk4-0000co-V5 for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 07:47:12 -0400 Original-Received: from [199.232.76.173] (port=49792 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MrVk4-0000ch-O8 for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 07:47:08 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38798) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MrVk4-0000op-2l for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2009 07:47:08 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8QBl5CD024975; Sat, 26 Sep 2009 04:47:05 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8QBZ3P3023010; Sat, 26 Sep 2009 04:35:03 -0700 Resent-Date: Sat, 26 Sep 2009 04:35:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 26 Sep 2009 11:35:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4543 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4543-submit@emacsbugs.donarmstrong.com id=B4543.125396440521821 (code B ref 4543); Sat, 26 Sep 2009 11:35:03 +0000 Original-Received: (at 4543) by emacsbugs.donarmstrong.com; 26 Sep 2009 11:26:45 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout3.012.net.il (mtaout3.012.net.il [84.95.2.7]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8QBQhcS021818 for <4543@emacsbugs.donarmstrong.com>; Sat, 26 Sep 2009 04:26:44 -0700 Original-Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KQK00F00T3INZ00@i_mtaout3.012.net.il> for 4543@emacsbugs.donarmstrong.com; Sat, 26 Sep 2009 14:26:36 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.56.156]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KQK00FMYT4CJ9N0@i_mtaout3.012.net.il>; Sat, 26 Sep 2009 14:26:36 +0300 (IDT) In-reply-to: <4ABDE2C5.2070808@gmx.at> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 26 Sep 2009 07:47:12 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31531 Archived-At: > Date: Sat, 26 Sep 2009 11:45:41 +0200 > From: martin rudalics > Cc: 4543@emacsbugs.donarmstrong.com > > The problem I see is that the value for new_frame_total_cols > calculated by change_frame_size_1 as > > /* Compute width of windows in F. > This is the width of the frame without vertical scroll bars. */ > new_frame_total_cols = FRAME_TOTAL_COLS_ARG (f, newwidth); > > /* Round up to the smallest acceptable size. */ > check_frame_size (f, &newheight, &newwidth); > > doesn't make sense for more complex window configurations. Why doesn't it make sense? The computed value of new_frame_total_cols is used to enlarge only the frame's root window: if (new_frame_total_cols != FRAME_TOTAL_COLS (f)) { set_window_width (FRAME_ROOT_WINDOW (f), new_frame_total_cols, 2); And for the root window, FRAME_TOTAL_COLS is correct, I think. The window configuration, however complex, does not affect the root window, does it? > I'm not sure, however, whether text-only terminals inherently rely > on these calculations. So the question I essentially ask is whether > the number of total columns of a frame's root-window invariantly > equals the width of that frame over all possible terminals. I think it does, yes. In any case, the code in change_frame_size_1 _is_ run on text-only terminals (or should I say for frames on text-only terminals, since we have multi-tty now).