From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>, 4543@emacsbugs.donarmstrong.com
Cc: monnier@IRO.UMontreal.CA
Subject: bug#4543: window-full-height-p
Date: Sat, 26 Sep 2009 14:28:39 +0300 [thread overview]
Message-ID: <83vdj6rllk.fsf@gnu.org> (raw)
In-Reply-To: <4ABDE2C5.2070808@gmx.at>
> Date: Sat, 26 Sep 2009 11:45:41 +0200
> From: martin rudalics <rudalics@gmx.at>
> Cc: 4543@emacsbugs.donarmstrong.com
>
> The problem I see is that the value for new_frame_total_cols
> calculated by change_frame_size_1 as
>
> /* Compute width of windows in F.
> This is the width of the frame without vertical scroll bars. */
> new_frame_total_cols = FRAME_TOTAL_COLS_ARG (f, newwidth);
>
> /* Round up to the smallest acceptable size. */
> check_frame_size (f, &newheight, &newwidth);
>
> doesn't make sense for more complex window configurations.
Why doesn't it make sense? The computed value of new_frame_total_cols
is used to enlarge only the frame's root window:
if (new_frame_total_cols != FRAME_TOTAL_COLS (f))
{
set_window_width (FRAME_ROOT_WINDOW (f), new_frame_total_cols, 2);
And for the root window, FRAME_TOTAL_COLS is correct, I think. The
window configuration, however complex, does not affect the root
window, does it?
> I'm not sure, however, whether text-only terminals inherently rely
> on these calculations. So the question I essentially ask is whether
> the number of total columns of a frame's root-window invariantly
> equals the width of that frame over all possible terminals.
I think it does, yes. In any case, the code in change_frame_size_1
_is_ run on text-only terminals (or should I say for frames on
text-only terminals, since we have multi-tty now).
next prev parent reply other threads:[~2009-09-26 11:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 3:28 bug#4543: window-full-height-p Glenn Morris
2009-09-24 7:04 ` martin rudalics
2009-09-25 6:18 ` Glenn Morris
2009-09-25 7:40 ` martin rudalics
2009-09-25 9:27 ` Eli Zaretskii
2009-09-25 12:59 ` martin rudalics
2009-09-25 13:38 ` Eli Zaretskii
2009-09-25 15:04 ` martin rudalics
2009-09-25 15:55 ` Eli Zaretskii
2009-09-25 19:05 ` martin rudalics
2009-09-25 20:16 ` Stefan Monnier
2009-09-26 9:45 ` martin rudalics
2009-09-25 14:37 ` Stefan Monnier
2009-09-26 9:45 ` martin rudalics
2009-09-26 11:28 ` Eli Zaretskii [this message]
2009-09-26 13:41 ` martin rudalics
2009-09-26 16:27 ` Eli Zaretskii
2009-09-26 19:01 ` martin rudalics
2009-09-26 20:17 ` Eli Zaretskii
2009-09-27 7:49 ` martin rudalics
2009-09-25 17:23 ` Glenn Morris
2009-09-25 19:05 ` martin rudalics
2009-09-25 20:10 ` Stefan Monnier
2009-10-02 7:12 ` Glenn Morris
2009-10-02 8:39 ` martin rudalics
2009-10-02 13:30 ` Stefan Monnier
2009-10-02 15:56 ` martin rudalics
2009-10-02 18:37 ` Glenn Morris
2009-10-03 8:20 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vdj6rllk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=4543@emacsbugs.donarmstrong.com \
--cc=monnier@IRO.UMontreal.CA \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).