From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9392: 24.0.50; rmail-forward produces messages in unsupported format that cannot be customized away Date: Fri, 02 Sep 2011 13:46:31 +0300 Message-ID: <83vctbcjco.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1314960471 529 80.91.229.12 (2 Sep 2011 10:47:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 2 Sep 2011 10:47:51 +0000 (UTC) Cc: 9392@debbugs.gnu.org To: Julien Danjou , handa@m17n.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 02 12:47:45 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QzRHk-0007At-Uo for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Sep 2011 12:47:45 +0200 Original-Received: from localhost ([::1]:41478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzRHk-0005oj-D7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Sep 2011 06:47:44 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:53392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzRHh-0005oG-Fn for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2011 06:47:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzRHg-0004WS-4R for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2011 06:47:41 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzRHf-0004WK-Tf for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2011 06:47:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QzRKw-0000dr-Mm; Fri, 02 Sep 2011 06:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Sep 2011 10:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9392 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9392-submit@debbugs.gnu.org id=B9392.13149606222421 (code B ref 9392); Fri, 02 Sep 2011 10:51:02 +0000 Original-Received: (at 9392) by debbugs.gnu.org; 2 Sep 2011 10:50:22 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QzRKH-0000cz-3z for submit@debbugs.gnu.org; Fri, 02 Sep 2011 06:50:21 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QzRKC-0000co-4P for 9392@debbugs.gnu.org; Fri, 02 Sep 2011 06:50:17 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LQW001005Q8HQ00@a-mtaout22.012.net.il> for 9392@debbugs.gnu.org; Fri, 02 Sep 2011 13:46:30 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.229.83.44]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LQW001SP5XG7330@a-mtaout22.012.net.il>; Fri, 02 Sep 2011 13:46:30 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 02 Sep 2011 06:51:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50545 Archived-At: > Date: Tue, 30 Aug 2011 01:47:06 -0400 > From: Eli Zaretskii > Cc: 9392@debbugs.gnu.org > > > From: Kenichi Handa > > Cc: 9392@debbugs.gnu.org > > Date: Tue, 30 Aug 2011 09:36:08 +0900 > > > > My last changes to rmail.el and rmailmm.el were before the > > release of 23.3, and for 23.3, I surely tested that > > rmail-forward worked with "emacs -Q" (but I must confess that I > > forgot to test the other configuration). > > > > > AFAICS, the #part tag is not inserted because rmail-forward > > > expects rmail-start-mail return a non-nil value, but with > > > message-user-agent it returns nil. > > > > So, It seems that something has been changed after the > > release of 23.3. > > You are right, it works in Emacs 23.3 with message-user-agent. So > this part (of rmail-forward not working in 'emacs -Q") is a recent > regression. The reason for this regression is this change in message.el: 2011-02-03 Julien Danjou * message.el (message-setup-1): Always generate References first. (message-mail): Return the return value of message-setup, not always t. (message-setup-1): Insert mail-header-separator with read-only and intangible properties set. I don't know what was the rationale for this change, because if message-setup calls message-setup-1, it will still return nil, since message-setup-1 returns nil unconditionally. The simple patch below fixes this particular regression. However, rmail-forward is still broken if mail-user-agent is set to sendmail-user-agent. That is a separate issue. So please do not close this bug, even if this patch is accepted by the Gnus developers. Here's the patch to message.el to restore the Emacs 23.3 default behavior of rmail-forward: === modified file 'lisp/gnus/message.el' --- lisp/gnus/message.el 2011-08-20 00:20:39 +0000 +++ lisp/gnus/message.el 2011-09-02 09:45:18 +0000 @@ -6530,7 +6530,9 @@ are not included." (message-position-point) ;; Allow correct handling of `message-checksum' in `message-yank-original': (set-buffer-modified-p nil) - (undo-boundary)) + (undo-boundary) + ;; rmail-start-mail expects message-mail to return t (Bug#9392) + t) (defun message-set-auto-save-file-name () "Associate the message buffer with a file in the drafts directory."