From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14409: emacs 24.3 -- windows Date: Thu, 16 May 2013 08:33:08 +0300 Message-ID: <83vc6j4hgr.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1368682513 7121 80.91.229.3 (16 May 2013 05:35:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 May 2013 05:35:13 +0000 (UTC) Cc: 14409@debbugs.gnu.org To: Frank P Esposito Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 16 07:35:12 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UcqqN-00058r-LH for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 07:35:11 +0200 Original-Received: from localhost ([::1]:57438 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcqqN-0004Fx-9X for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 May 2013 01:35:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcqqB-00045Q-EA for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 01:35:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ucqq6-0000ei-JY for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 01:34:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ucqq6-0000ee-H5 for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 01:34:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UcqqE-00028q-SO for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 01:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2013 05:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14409 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14409-submit@debbugs.gnu.org id=B14409.13686824428070 (code B ref 14409); Thu, 16 May 2013 05:35:02 +0000 Original-Received: (at 14409) by debbugs.gnu.org; 16 May 2013 05:34:02 +0000 Original-Received: from localhost ([127.0.0.1]:46883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcqpG-000267-1l for submit@debbugs.gnu.org; Thu, 16 May 2013 01:34:02 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:56724) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcqpC-00025U-Tj for 14409@debbugs.gnu.org; Thu, 16 May 2013 01:33:59 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MMV00400M126500@a-mtaout22.012.net.il> for 14409@debbugs.gnu.org; Thu, 16 May 2013 08:33:11 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MMV003Q5M3ATBD0@a-mtaout22.012.net.il>; Thu, 16 May 2013 08:33:11 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74317 Archived-At: > Date: Wed, 15 May 2013 22:31:48 -0400 > From: Frank P Esposito > > You need to fix the code, or update the readme / install (text) files to > note that this version of emacs DOES NOT COMPILE with versions of visual > studio that ARE NOT C99 compliant. There was no intent to break compilation with Studio 2003. It's just that the number of people who use that seems to be vanishingly small, and in particular none of them tried the pretest version and reported problems. > there are references to defines that are part of stdint.h (C99) -- you > need to define them or not use them We have a replacement stdint.h in nt/inc. If something is missing from there, please tell what that is. > it seems that there is new code in "charset.c charset.h" that have very > complex macros that are imbedded in other complex macros > that expand to something like (see below) which is impossible to debug -- > this is causing the error > > coding.c > coding.c(2604) : error C2065: 'value' : undeclared identifier > coding.c(2604) : error C2143: syntax error : missing ':' before ')' > coding.c(2604) : error C2059: syntax error : ')' > coding.c(2604) : error C2059: syntax error : ')' > coding.c(2604) : error C2059: syntax error : ')' > coding.c(2604) : fatal error C1013: compiler limit : too many open > parentheses This is about CODING_CHAR_CHARSET, right? But then I don't understand the expansion you are showing, which starts with this: > charset = (charset_table + (preferred_charset_id)); > do { ptrdiff_t offset; charset_map_loaded = 0; result = (((((sizeof > ((c) + 0)) > (sizeof ((0x80) + 0)) ? (sizeof ((c) + 0)) : (sizeof ((0x80) + > 0))) <= sizeof (unsigned) ? ((c) + (unsigned) 0) < ((0x80) + (unsigned) 0) > : ((c) + (unsigned long) 0) < ((0x80) + (unsigned long) 0)) && I see no "result = ...", or anything that could expand into it, the definition of CODING_CHAR_CHARSET. What am I missing? > I would be willing work to get this cleaned up -- VC 7.1 supports inline > functions Please do, and thanks. Just one request: try to keep the MSVC-specific stuff separate, preferably somewhere under the nt/ directory (e.g., nt/inc/ms-w32.h) or in a clearly #ifdef'ed section at the beginning of a .c or .h file in src/, so that these changes don't make reading of the code harder. Thanks.